handle case sensitivity consistently

mojolicious · Oct 26, 2013 · 49a4ffc · 49a4ffc
1 parent 95938f2
commit 49a4ffc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
-4.51  2013-10-25
+4.51  2013-10-26
+  - Fixed case sensitivity bug in multipart form handling.
 
 4.50  2013-10-22
   - Deprecated Mojo::UserAgent::app in favor of

diff --git a/lib/Mojo/Message.pm b/lib/Mojo/Message.pm
@@ -277,9 +277,9 @@ sub _parse_formdata {
     }
 
     next unless my $disposition = $part->headers->content_disposition;
-    my ($filename) = $disposition =~ /[; ]filename\s*=\s*"?([^"]*)"?/;
+    my ($filename) = $disposition =~ /[; ]filename\s*=\s*"?([^"]*)"?/i;
     next if ($upload && !defined $filename) || (!$upload && defined $filename);
-    my ($name) = $disposition =~ /[; ]name\s*=\s*"?([^";]+)"?/;
+    my ($name) = $disposition =~ /[; ]name\s*=\s*"?([^";]+)"?/i;
     if ($charset) {
       $name     = decode($charset, $name)     // $name     if $name;
       $filename = decode($charset, $filename) // $filename if $filename;

diff --git a/t/mojo/request_cgi.t b/t/mojo/request_cgi.t
@@ -443,7 +443,7 @@ is $req->content->progress, 0, 'right progress';
 $req->parse("--8jXGX\x0d\x0a");
 is $req->content->progress, 9, 'right progress';
 $req->parse(
-  "Content-Disposition: form-data; name = file; filename = file.txt\x0d\x0a"
+  "Content-Disposition: Form-Data; Name = file; Filename = file.txt\x0d\x0a"
     . "Content-Type: application/octet-stream\x0d\x0a\x0d\x0a");
 is $req->content->progress, 117, 'right progress';
 $req->parse('11023456789');