Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
base: 0c70201888d6
Choose a base ref
...
head repository: opal/opal
compare: d5af5a5bcc69
Choose a head ref
  • 7 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 12, 2013

  1. Allow Numeric#to_s to convert to different radices

    @jgaskins
    jgaskins committed Sep 12, 2013
    Configuration menu
    Copy the full SHA
    bb82a48 View commit details
    Browse the repository at this point in the history

  2. Make Numeric#divmod function like Ruby's version 

    JavaScript modulo works differently from Ruby's version when either side
is negative. This would cause some pretty frustrating errors in Opal
apps. This commit fixes that with a special case if either side of the
expression is negative.
    @jgaskins
    jgaskins committed Sep 12, 2013
    Configuration menu
    Copy the full SHA
    6616e27 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2013

  1. Add Numeric#to_s spec from RubySpec's Fixnum#to_s

    @jgaskins
    jgaskins committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    62186a6 View commit details
    Browse the repository at this point in the history

  2. Use radix conversion in JS

    @jgaskins
    jgaskins committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    b5ed3b7 View commit details
    Browse the repository at this point in the history

  3. Remove DIGIT_MAP constant 

    No longer necessary since we're not converting number bases in Ruby.
    @jgaskins
    jgaskins committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    6afd20f View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary explicit return

    @jgaskins
    jgaskins committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    11857bd View commit details
    Browse the repository at this point in the history

  5. Merge pull request #362 from jgaskins/numeric-to_s-with-radices 

    Allow Numeric#to s to use radices
    @adambeynon
    adambeynon committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    d5af5a5 View commit details
    Browse the repository at this point in the history