fixed integration tests which were breaking in non-clean builds #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, this is ready for review now. Thanks. |
|
Resolved with: ba01f43 Addresses: https://www.pivotaltracker.com/story/show/69740244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/69740244 (HTTP API Module fails when not installed with clean)
This PR contains:
A fix for HTTP API Module tests that were failing when the build was run with
mvn installinstead ofmvn clean install(this was mostly a case of not using the getRandomUniquePid() method, of the parent AbstractResourceIT class, to generate pids).A similar fix for tests in fcrepo-auth-common (which could be seen to fail once the fcrepo-http-api tests had been fixed).
Code reformatting for the touched tests (lines allowed at 120 characters now, instead of 80), fixes indentation (which will conform to checkstyle rules (once tests are run against them)), etc.
Removal of imports which weren't being used (Eclipse does this automagically when it does the normal reformatting).
Addition of a getRandomUniquePid() method in the AbstractResourceIT class in the fcrepo-auth-common package (similar to the AbstractResourceIT class in the fcrepo-http-api package) and a preference for using that method in the parent class rather than each test calling UUID directly (across both packages).
All packages are building now with:
mvn install