Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 9ac75d1f06d0
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 873b5f8428fc
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 26, 2013

  1. buffer: add NativeBuffer API 

    Due to a lot of the util.is* checks there was much unnecessary overhead
for the most common use case of Buffer. Which is creating a new Buffer
instance for data from incoming I/O. NativeBuffer is a simple way to
bypass all the unneeded checks and simply hand back a Buffer instance
while setting the length.
    @trevnorris
    trevnorris committed Aug 26, 2013
    Copy the full SHA
    16a60ed View commit details
    Browse the repository at this point in the history

  2. buffer: fix assert fail from JS API 

    Length arguments passed to SlowBuffer were coerced to Int32, not Uint32,
so passing a negative number would throw the following:

node: ../src/smalloc.cc:244: void node::smalloc::Alloc(): Assertion `length <= kMaxLength' failed.
Aborted (core dumped)

That has been fixed by coercing to Uint32 and comparing the value
against kMaxLength.
    @trevnorris
    trevnorris committed Aug 26, 2013
    Copy the full SHA
    873b5f8 View commit details
    Browse the repository at this point in the history