Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A lot of files without "_spec.rb" suffix in the spec directory exist. #2174

Closed
k77ch7 opened this issue Nov 11, 2014 · 3 comments
Closed

A lot of files without "_spec.rb" suffix in the spec directory exist. #2174

k77ch7 opened this issue Nov 11, 2014 · 3 comments
Assignees
@headius
Labels
JRuby 9000 tests
Milestone
JRuby 9.0.0.0-pre1

Comments

@k77ch7
Copy link
Contributor

k77ch7 commented Nov 11, 2014

A lot of files without "_spec.rb" suffix in the spec directory exist. These files don't run at travis-ci. For example, GH-1446_line_number_in_warnings.rb don’t run in the "spec:regression" task. The cause of this is the definition of the pattern in the rakelib/rspec.rb.
https://github.com/jruby/jruby/blob/master/rakelib/rspec.rake#L52
@k77ch7 k77ch7 mentioned this issue Nov 12, 2014
Merged
This was referenced Nov 25, 2014
Merged
Merged
Merged
@rtyler
Copy link

rtyler commented Dec 9, 2014

Considering the number of merged commits that reference this issue, is it safe to close it @k77ch7 ?

@k77ch7
Copy link
Contributor Author

k77ch7 commented Dec 10, 2014

@rtyler This issue still can not be closed. The following files are not renamed.

  • GH-1695_bigdecimal_and_rational_multiplication_rounds_the_rational_number.rb
  • GH-1940_symlink_load_path_should_not_expand_in_FILE.rb
  • GH-2132_catch_nonlocal_return_lje.rb
  • GH-2198_test_access_protections.rb
  • GH-2264_illegal_hex_characters_in_escape_pattern.rb
  • GH-2284_stabby_lambda_constant_lookup.rb
  • GH-652_time_add.rb

This was referenced Dec 11, 2014
Merged
Merged
headius added a commit that referenced this issue Jan 12, 2015
@headius
_spec'ify last couple files mentioned in #2174.
c3d9dea
@headius
Copy link
Member

headius commented Jan 12, 2015

Fixed the last two files mentioned in c3d9dea.

@headius headius closed this as completed Jan 12, 2015
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 12, 2015
@headius headius self-assigned this Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@headius headius

Labels
JRuby 9000 tests
Projects
None yet
Milestone
JRuby 9.0.0.0-pre1
Development

No branches or pull requests
3 participants
@headius @rtyler @k77ch7