Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5819bc7f951f
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 922e631b4f56
Choose a head ref
  • 12 commits
  • 20 files changed
  • 1 contributor

Commits on Nov 28, 2014

  1. Tag new failing arity specs.

    eregon committed Nov 28, 2014
    Copy the full SHA
    749130d View commit details
  2. Tag new failing Time specs.

    eregon committed Nov 28, 2014
    Copy the full SHA
    3f5adb8 View commit details
  3. Copy the full SHA
    e08aa42 View commit details
  4. Copy the full SHA
    cc718d7 View commit details
  5. Copy the full SHA
    a1dd8e1 View commit details
  6. Copy the full SHA
    6c936c2 View commit details
  7. Copy the full SHA
    ad768cc View commit details
  8. Copy the full SHA
    5763657 View commit details
  9. Copy the full SHA
    98ce311 View commit details
  10. Copy the full SHA
    d68b2be View commit details
  11. Copy the full SHA
    0b3a758 View commit details
  12. Tag new failing #to_h specs.

    eregon committed Nov 28, 2014
    Copy the full SHA
    922e631 View commit details
7 changes: 7 additions & 0 deletions spec/tags/ruby/core/array/to_h_tags.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
fails:Array#to_h converts empty array to empty hash
fails:Array#to_h converts [key, value] pairs to a hash
fails:Array#to_h uses the last value of a duplicated key
fails:Array#to_h calls #to_ary on contents
fails:Array#to_h raises TypeError if an element is not an array
fails:Array#to_h raises ArgumentError if an element is not a [key, value] pair
fails:Array#to_h does not accept arguments
1 change: 1 addition & 0 deletions spec/tags/ruby/core/dir/element_reference_tags.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
fails(JRUBY-5667):Dir.[] splits the string on \0 if there is only one string given
fails:Dir.[] raises an Encoding::CompatibilityError if the argument encoding is not compatible with US-ASCII
fails:Dir.[] returns Strings in the encoding of the pattern
fails:Dir.[] splits the string on \0 if there is only one string given
1 change: 1 addition & 0 deletions spec/tags/ruby/core/dir/fileno_tags.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Dir#fileno returns the file descriptor of the dir
1 change: 1 addition & 0 deletions spec/tags/ruby/core/dir/glob_tags.txt
Original file line number Diff line number Diff line change
@@ -2,3 +2,4 @@ fails(JRUBY-5667):Dir.glob splits the string on \0 if there is only one string g
fails:Dir.glob raises an Encoding::CompatibilityError if the argument encoding is not compatible with US-ASCII
fails:Dir.glob with encoding returns Strings in the encoding of the pattern
fails:Dir.glob matches nothing when given an empty list of paths
fails:Dir.glob splits the string on \0 if there is only one string given
7 changes: 7 additions & 0 deletions spec/tags/ruby/core/enumerable/to_h_tags.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
fails:Enumerable#to_h converts empty enumerable to empty hash
fails:Enumerable#to_h converts yielded [key, value] pairs to a hash
fails:Enumerable#to_h uses the last value of a duplicated key
fails:Enumerable#to_h calls #to_ary on contents
fails:Enumerable#to_h forwards arguments to #each
fails:Enumerable#to_h raises TypeError if an element is not an array
fails:Enumerable#to_h raises ArgumentError if an element is not a [key, value] pair
1 change: 1 addition & 0 deletions spec/tags/ruby/core/exception/signal_exception_tags.txt
Original file line number Diff line number Diff line change
@@ -9,3 +9,4 @@ fails:SignalException.new raises an exception with an invalid signal name
fails:SignalException.new takes an optional message argument with a signal number
fails:SignalException.new raises an exception for an optional argument with a signal name
critical(crash):rescueing SignalException raises a SignalException when sent a signal
fails:rescueing SignalException raises a SignalException when sent a signal
2 changes: 2 additions & 0 deletions spec/tags/ruby/core/io/popen_tags.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
unstable(JRUBY-4171,linux,intermittent failure):IO.popen writes to a write-only pipe
fails:IO.popen starts returns a forked process if the command is -
fails:IO.popen does not throw an exception if child exited and has been waited for
fails:IO.popen with a leading ENV Hash accepts a single String command with a trailing Hash of Process.exec options, and an IO mode
fails:IO.popen with a leading ENV Hash accepts an Array command with a separate trailing Hash of Process.exec options, and an IO mode
1 change: 1 addition & 0 deletions spec/tags/ruby/core/kernel/backtick_tags.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
fails:Kernel#` sets $? to the exit status of the executed sub-process
fails:Kernel#` raises an Errno::ENOENT if the command is not executable
2 changes: 2 additions & 0 deletions spec/tags/ruby/core/kernel/exec_tags.txt
Original file line number Diff line number Diff line change
@@ -10,3 +10,5 @@ fails:Kernel.exec with a command array uses the first element as the command nam
fails:Kernel.exec with a command array coerces the argument using to_ary
fails:Kernel#exec (environment variables) unsets other environment variables when given a true :unsetenv_others option
fails:Kernel.exec (environment variables) unsets other environment variables when given a true :unsetenv_others option
fails:Kernel#exec with an options Hash with Integer option keys maps the key to a file descriptor in the child that inherits the file descriptor from the parent specified by the value
fails:Kernel.exec with an options Hash with Integer option keys maps the key to a file descriptor in the child that inherits the file descriptor from the parent specified by the value
2 changes: 2 additions & 0 deletions spec/tags/ruby/core/kernel/spawn_tags.txt
Original file line number Diff line number Diff line change
@@ -121,7 +121,9 @@ fails:Kernel#spawn raises a TypeError if given a symbol as :pgroup option
fails:Kernel#spawn does not close file descriptors >= 3 in the child process when given a false :close_others option and fds are set close_on_exec=false
fails:Kernel#spawn when passed :chdir changes to the directory passed for :chdir
fails:Kernel#spawn when passed :chdir calls #to_path to convert the :chdir value
fails:Kernel#spawn with Integer option keys maps the key to a file descriptor in the child that inherits the file descriptor from the parent specified by the value
fails:Kernel.spawn raises a TypeError if given a symbol as :pgroup option
fails:Kernel.spawn does not close file descriptors >= 3 in the child process when given a false :close_others option and fds are set close_on_exec=false
fails:Kernel.spawn when passed :chdir changes to the directory passed for :chdir
fails:Kernel.spawn when passed :chdir calls #to_path to convert the :chdir value
fails:Kernel.spawn with Integer option keys maps the key to a file descriptor in the child that inherits the file descriptor from the parent specified by the value
7 changes: 7 additions & 0 deletions spec/tags/ruby/core/method/arity_tags.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
fails:"Method#arity returns positive values for method definition \n def m(a:) end\n def n(a:, b:) end\n def o(a: 1, b:, c:, d: 2) end"
fails:"Method#arity returns positive values for method definition \n def m(a, b:) end\n def n(a, b:, &l) end"
fails:"Method#arity returns positive values for method definition \n def m(a, b, c:, d: 1) end\n def n(a, b, c:, d: 1, **k, &l) end"
fails:"Method#arity returns negative values for method definition \n def m(a: 1) end\n def n(a: 1, b: 2) end"
fails:"Method#arity returns negative values for method definition \n def m(**k, &l) end\n def n(*a, **k) end\n def o(a: 1, b: 2, **k) end"
fails:"Method#arity returns negative values for method definition \n def m(a=1, *b, c:, d: 2, **k, &l) end"
fails:"Method#arity returns negative values for method definition \n def m(a, b=1, *c, d, e:, f: 2, **k, &l) end\n def n(a, b=1, *c, d:, e:, f: 2, **k, &l) end\n def o(a=0, b=1, *c, d, e:, f: 2, **k, &l) end\n def p(a=0, b=1, *c, d:, e:, f: 2, **k, &l) end"
1 change: 1 addition & 0 deletions spec/tags/ruby/core/objectspace/define_finalizer_tags.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
fails:ObjectSpace.define_finalizer calls finalizer on process termination
fails:ObjectSpace.define_finalizer calls finalizer at exit even if it is self-referencing
fails:ObjectSpace.define_finalizer raises a RuntimeError if the object is not garbage collectable
15 changes: 15 additions & 0 deletions spec/tags/ruby/core/proc/arity_tags.txt
Original file line number Diff line number Diff line change
@@ -3,3 +3,18 @@ fails:Proc#arity returns 0 for a Proc taking one optional argument
fails:Proc#arity returns 1 for a Proc taking |a, b = 0| argument
fails:Proc#arity returns 1 for a Proc taking |a, b = 0, c = 0| argument
fails:Proc#arity returns 1 for a Proc taking |(a, b), c = 0| argument
fails:"Proc#arity for instances created with -> () { } returns positive values for definition \n @a = -> (a:) { }\n @b = -> (a:, b:) { }\n @c = -> (a: 1, b:, c:, d: 2) { }"
fails:"Proc#arity for instances created with -> () { } returns positive values for definition \n @a = -> (a, b:) { }\n @b = -> (a, b:, &l) { }"
fails:"Proc#arity for instances created with -> () { } returns positive values for definition \n @a = -> (a, b, c:, d: 1) { }\n @b = -> (a, b, c:, d: 1, **k, &l) { }"
fails:"Proc#arity for instances created with -> () { } returns negative values for definition \n @a = -> (a: 1) { }\n @b = -> (a: 1, b: 2) { }"
fails:"Proc#arity for instances created with -> () { } returns negative values for definition \n @a = -> (**k, &l) { }\n @b= -> (*a, **k) { }\n @c = ->(a: 1, b: 2, **k) { }"
fails:"Proc#arity for instances created with -> () { } returns negative values for definition \n @a = -> (a=1, *b, c:, d: 2, **k, &l) { }"
fails:"Proc#arity for instances created with -> () { } returns negative values for definition \n @a = -> (a, b=1, *c, d, e:, f: 2, **k, &l) { }\n @b = -> (a, b=1, *c, d:, e:, f: 2, **k, &l) { }\n @c = -> (a=0, b=1, *c, d, e:, f: 2, **k, &l) { }\n @d = -> (a=0, b=1, *c, d:, e:, f: 2, **k, &l) { }"
fails:"Proc#arity for instances created with lambda { || } returns positive values for definition \n @a = lambda { |a:| }\n @b = lambda { |a:, b:| }\n @c = lambda { |a: 1, b:, c:, d: 2| }"
fails:"Proc#arity for instances created with lambda { || } returns positive values for definition \n @a = lambda { |a, b:| }\n @b = lambda { |a, b:, &l| }"
fails:"Proc#arity for instances created with lambda { || } returns positive values for definition \n @a = lambda { |a, b, c:, d: 1| }\n @b = lambda { |a, b, c:, d: 1, **k, &l| }"
fails:"Proc#arity for instances created with lambda { || } returns negative values for definition \n @a = lambda { |a: 1| }\n @b = lambda { |a: 1, b: 2| }"
fails:"Proc#arity for instances created with lambda { || } returns negative values for definition \n @a = lambda { |**k, &l| }\n @b = lambda { |*a, **k| }\n @c = lambda { |a: 1, b: 2, **k| }"
fails:"Proc#arity for instances created with lambda { || } returns negative values for definition \n @a = lambda { |a=1, *b, c:, d: 2, **k, &l| }"
fails:"Proc#arity for instances created with lambda { || } returns negative values for definition \n @a = lambda { |(a, (*b, c)), d=1| }\n @b = lambda { |a, (*b, c), d, (*e), (*), **k| }\n @c = lambda { |a, (b, c), *, d:, e: 2, **| }"
fails:"Proc#arity for instances created with lambda { || } returns negative values for definition \n @a = lambda { |a, b=1, *c, d, e:, f: 2, **k, &l| }\n @b = lambda { |a, b=1, *c, d:, e:, f: 2, **k, &l| }\n @c = lambda { |a=0, b=1, *c, d, e:, f: 2, **k, &l| }\n @d = lambda { |a=0, b=1, *c, d:, e:, f: 2, **k, &l| }"
1 change: 1 addition & 0 deletions spec/tags/ruby/core/process/exec_tags.txt
Original file line number Diff line number Diff line change
@@ -9,3 +9,4 @@ fails:Process.exec with a command array uses the first element as the command na
fails:Process.exec with a command array coerces the argument using to_ary
fails:Process.exec (environment variables) unsets other environment variables when given a true :unsetenv_others option
fails:Process.exec with a command array raises an ArgumentError if the Array does not have exactly two elements
fails:Process.exec with an options Hash with Integer option keys maps the key to a file descriptor in the child that inherits the file descriptor from the parent specified by the value
1 change: 1 addition & 0 deletions spec/tags/ruby/core/process/spawn_tags.txt
Original file line number Diff line number Diff line change
@@ -60,3 +60,4 @@ fails:Process.spawn raises a TypeError if given a symbol as :pgroup option
fails:Process.spawn does not close file descriptors >= 3 in the child process when given a false :close_others option and fds are set close_on_exec=false
fails:Process.spawn when passed :chdir changes to the directory passed for :chdir
fails:Process.spawn when passed :chdir calls #to_path to convert the :chdir value
fails:Process.spawn with Integer option keys maps the key to a file descriptor in the child that inherits the file descriptor from the parent specified by the value
1 change: 1 addition & 0 deletions spec/tags/ruby/core/regexp/compile_tags.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
fails:Regexp.compile given a String with escaped characters returns a Regexp with source String having US-ASCII encoding if only 7-bit ASCII characters are present regardless of the input String's encoding
fails:Regexp.compile given a String with escaped characters returns a Regexp with source String having US-ASCII encoding if UTF-8 escape sequences using only 7-bit ASCII are present
fails:Regexp.compile given a String uses ASCII_8BIT encoding if third argument is 'n' or 'none' (case insensitive) and non-ascii characters
1 change: 1 addition & 0 deletions spec/tags/ruby/core/regexp/new_tags.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
fails:Regexp.new given a String with escaped characters returns a Regexp with source String having US-ASCII encoding if only 7-bit ASCII characters are present regardless of the input String's encoding
fails:Regexp.new given a String with escaped characters returns a Regexp with source String having US-ASCII encoding if UTF-8 escape sequences using only 7-bit ASCII are present
fails:Regexp.new given a String uses ASCII_8BIT encoding if third argument is 'n' or 'none' (case insensitive) and non-ascii characters
2 changes: 2 additions & 0 deletions spec/tags/ruby/core/string/scrub_tags.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
fails:String#scrub with a custom replacement replaces groups of sequences together with a single replacement
fails:String#scrub with a block replaces invalid byte sequences
fails:String#scrub! modifies self for valid strings
fails:String#scrub! accepts blocks
1 change: 1 addition & 0 deletions spec/tags/ruby/core/time/minus_tags.txt
Original file line number Diff line number Diff line change
@@ -3,3 +3,4 @@ fails:Time#- maintains microseconds precision
fails:Time#- maintains nanoseconds precision
fails:Time#- maintains subseconds precision
fails:Time#- does not return a subclass instance
fails:Time#- returns a time with nanoseconds precision between two time objects
7 changes: 7 additions & 0 deletions spec/tags/ruby/core/unboundmethod/arity_tags.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
fails:"UnboundMethod#arity returns positive values for method definition \n def m(a:) end\n def n(a:, b:) end\n def o(a: 1, b:, c:, d: 2) end"
fails:"UnboundMethod#arity returns positive values for method definition \n def m(a, b:) end\n def n(a, b:, &l) end"
fails:"UnboundMethod#arity returns positive values for method definition \n def m(a, b, c:, d: 1) end\n def n(a, b, c:, d: 1, **k, &l) end"
fails:"UnboundMethod#arity returns negative values for method definition \n def m(a: 1) end\n def n(a: 1, b: 2) end"
fails:"UnboundMethod#arity returns negative values for method definition \n def m(**k, &l) end\n def n(*a, **k) end\n def o(a: 1, b: 2, **k) end"
fails:"UnboundMethod#arity returns negative values for method definition \n def m(a=1, *b, c:, d: 2, **k, &l) end"
fails:"UnboundMethod#arity returns negative values for method definition \n def m(a, b=1, *c, d, e:, f: 2, **k, &l) end\n def n(a, b=1, *c, d:, e:, f: 2, **k, &l) end\n def o(a=0, b=1, *c, d, e:, f: 2, **k, &l) end\n def p(a=0, b=1, *c, d:, e:, f: 2, **k, &l) end"