better CGI tests

mojolicious · Dec 16, 2011 · 5552b32 · 5552b32
1 parent d392f4e
commit 5552b32
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/Mojo/Server/CGI.pm b/lib/Mojo/Server/CGI.pm
@@ -57,7 +57,7 @@ sub run {
   $res->fix_headers;
   my $code    = $res->code    || 404;
   my $message = $res->message || $res->default_message;
-  $res->headers->header(Status => "$code $message") unless $self->nph;
+  $res->headers->status("$code $message") unless $self->nph;
   $offset = 0;
   while (1) {
     my $chunk = $res->get_header_chunk($offset);

diff --git a/t/mojo/cgi.t b/t/mojo/cgi.t
@@ -1,6 +1,6 @@
 use Mojo::Base -strict;
 
-use Test::More tests => 16;
+use Test::More tests => 20;
 
 use Mojo::Message::Response;
 use Mojolicious::Lite;
@@ -60,6 +60,7 @@ my $message = '';
 my $res =
   Mojo::Message::Response->new->parse("HTTP/1.1 200 OK\x0d\x0a$message");
 is $res->code, 200, 'rigth status';
+is $res->headers->status, '200 OK', 'right "Status" value';
 is $res->headers->content_type, 'text/html;charset=UTF-8',
   'right "Content-Type" value';
 like $res->body, qr/Mojo/, 'right content';
@@ -81,6 +82,7 @@ $message = '';
 }
 $res = Mojo::Message::Response->new->parse($message);
 is $res->code, 200, 'rigth status';
+is $res->headers->status, undef, 'no "Status" value';
 is $res->headers->content_type, 'text/html;charset=UTF-8',
   'right "Content-Type" value';
 like $res->body, qr/Mojo/, 'right content';
@@ -107,7 +109,8 @@ $message = '';
 }
 like $message, qr/chunked/, 'is chunked';
 $res = Mojo::Message::Response->new->parse("HTTP/1.1 200 OK\x0d\x0a$message");
-is $res->code, 200,       'rigth status';
+is $res->code, 200, 'rigth status';
+is $res->headers->status, '200 OK', 'right "Status" value';
 is $res->body, '1234567', 'right content';
 
 # Parameters
@@ -128,6 +131,7 @@ $message = '';
 }
 $res = Mojo::Message::Response->new->parse("HTTP/1.1 200 OK\x0d\x0a$message");
 is $res->code, 200, 'rigth status';
+is $res->headers->status, '200 OK', 'right "Status" value';
 is $res->headers->content_type, 'application/json',
   'right "Content-Type" value';
 is $res->headers->content_length, 27, 'right "Content-Length" value';