-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
Does this work as-is with our knife solo chef runs? (And has it been tested?) |
It does work as a drop in replacement, the only difference is that you need to specify @sethvargo got any pointers? Additionally, I've tested it on a fresh AWS instance and things were 👍 |
@skottler you can add ENV['BERKSHELF_PATH'] = 'whatever' to the very top of your Berksfile (which isn't exactly the same, but has the same effect). We don't currently support "sticky" options like bundler (although it is being considered for a future release). I'll take a look at the PR and drop in some comments. Let me know how I can help 😄 |
cookbook "imagemagick" | ||
cookbook "iptables", git: "https://github.com/phlipper/iptables" | ||
cookbook "java" | ||
cookbook "jenkins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as an FYI, this is about to change bigtime on monday. Might want to lock to the latest version before I merge: sous-chefs/jenkins#114
@skottler If you lock those versions I'll merge this. Also, correct me if I'm wrong, but I think the knife solo chef run will still work even if you don't set the path. That's only necessary to keep them in the same directory as before for consistency. Right? |
Just out of curiosity, what was the impetus for this change? I don't have an opinion either way, but it seems like a lateral move. |
@phlipper the chef community generally seems to have moved toward favoring Berkshelf. I totally agree that it's a zero-win except that the repo will look familiar to people already using Berkshelf which will make them (theoretically at least) more likely to contribute. @dwradcliffe locking now. |
Whoops. The buttons are way too close together below the comment text area 💩 |
@skottler ctrl + enter saves the day 😄 |
No description provided.