Skip to content
This repository has been archived by the owner on Nov 30, 2017. It is now read-only.

Switch to berkshelf #154

Merged
merged 2 commits into from
Jan 15, 2014
Merged

Switch to berkshelf #154

merged 2 commits into from
Jan 15, 2014

Conversation

skottler
Copy link
Member

No description provided.

@dwradcliffe
Copy link
Member

Does this work as-is with our knife solo chef runs? (And has it been tested?)

@skottler
Copy link
Member Author

It does work as a drop in replacement, the only difference is that you need to specify --path chef/cookbooks since berkshelf will install to $HOME/.berkshelf/cookbooks by default. I wonder if there's a way to change this for the whole repo so users can just type berks and be off to the races.

@sethvargo got any pointers?

Additionally, I've tested it on a fresh AWS instance and things were 👍

@sethvargo
Copy link

@skottler you can add

ENV['BERKSHELF_PATH'] = 'whatever'

to the very top of your Berksfile (which isn't exactly the same, but has the same effect). We don't currently support "sticky" options like bundler (although it is being considered for a future release). I'll take a look at the PR and drop in some comments. Let me know how I can help 😄

cookbook "imagemagick"
cookbook "iptables", git: "https://github.com/phlipper/iptables"
cookbook "java"
cookbook "jenkins"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an FYI, this is about to change bigtime on monday. Might want to lock to the latest version before I merge: sous-chefs/jenkins#114

@dwradcliffe
Copy link
Member

@skottler If you lock those versions I'll merge this.

Also, correct me if I'm wrong, but I think the knife solo chef run will still work even if you don't set the path. That's only necessary to keep them in the same directory as before for consistency. Right?

@phlipper
Copy link
Contributor

Just out of curiosity, what was the impetus for this change? I don't have an opinion either way, but it seems like a lateral move.

@skottler
Copy link
Member Author

@phlipper the chef community generally seems to have moved toward favoring Berkshelf. I totally agree that it's a zero-win except that the repo will look familiar to people already using Berkshelf which will make them (theoretically at least) more likely to contribute.

@dwradcliffe locking now.

@skottler skottler closed this Jan 15, 2014
@skottler skottler reopened this Jan 15, 2014
@skottler
Copy link
Member Author

Whoops. The buttons are way too close together below the comment text area 💩

@sethvargo
Copy link

@skottler ctrl + enter saves the day 😄

dwradcliffe added a commit that referenced this pull request Jan 15, 2014
@dwradcliffe dwradcliffe merged commit 4ee72c5 into rubygems:master Jan 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants