Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/milkymist
base: f6c7474
Choose a base ref
...
head repository: m-labs/milkymist
compare: 6e8c7b1
Choose a head ref
  • 11 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 19, 2011

  1. softusb: 4 kB hack

    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    f1c0fe7 View commit details
    Browse the repository at this point in the history
  2. softusb: use OE# of port A for trigger

    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    c8111e5 View commit details
    Browse the repository at this point in the history
  3. softusb: send SETUP and DATA0 back-to-back

    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    edf599e View commit details
    Browse the repository at this point in the history
  4. softusb: simplify and correct data toggle in control transactions

    This patch does three things:
    
    1) it replaces get_data_token with a simpler and more efficient
       version that doesn't unconditionally toggle
    
    2) it only toggles the transmitter-side sequence if the DATAx
       packet is acknowledged (USB 1.1 sec 8.6 pg 168 and USB 2.0
       sec 8.6 pg 232)
    
    3) it always sends DATA1 in the status stage, in accordance with
       USB 1.1 sec 8.5.2 pg 165 and USB 2.0 sec 8.5.3 pg 226.
    
    In testing, this patch reduced the probability of the low-speed device
    used (the Rii RF keyboard) registering. This seems to simply be the
    effect of bugs eliminated in later patches having a greater effect,
    and does not constitute a regression of code correctness.
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    4e255d0 View commit details
    Browse the repository at this point in the history
  5. softusb: in SETUP, only use IN data with the right sequence bit

    This also removes the functional regression of the previous commit.
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    f246bcf View commit details
    Browse the repository at this point in the history
  6. softusb: use toggle() also for bulk/interrupt

    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    7c9748b View commit details
    Browse the repository at this point in the history
  7. softusb: swap in_reply and out_reply

    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    9a26965 View commit details
    Browse the repository at this point in the history
  8. softusb: move all IN transfers to function usb_in

    Besides reducing some redundancy, this patch also makes the following
    changes:
    
    - retry on timeout (e.g., if the DATAx packet was garbled) in the data
      stage of control transfers instead of failing the entire transfer
    
    - retry IN tranfers in the status stage
    
    - reject IN transfers in the status stage if they have the wrong
      sequence bit (more USB 1.1 sec 8.5.2 and USB 2.0 sec 8.5.3)
    
    - slightly reduce the information in debugging output since control
      and bulk/interrupt now use the same code path for IN transfers
    
    The streamlined code path also makes full-speed work occasionally.
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    d5ae456 View commit details
    Browse the repository at this point in the history
  9. softusb: move all OUT transfers to function usb_out

    This is mainly cosmetic, to reduce the amount of code. It adds
    retry on timeout, though.
    
    Again, as a side-effect, debug messages become a bit less detailed.
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    0ff5764 View commit details
    Browse the repository at this point in the history
  10. suftusb: remove one now unused debug message

    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    309d30d View commit details
    Browse the repository at this point in the history
  11. Revert 4KB hack

    Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    6e8c7b1 View commit details
    Browse the repository at this point in the history