Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7304a620ecc7
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 1f9f86349410
Choose a head ref
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Aug 15, 2013

  1. http: Write hex/base64 chunks properly

    This removes a dubious performance "optimization" where strings body
    chunks were concatenated to one another (and to the headers) without any
    regard for their encoding.
    isaacs committed Aug 15, 2013
    Copy the full SHA
    ce3d184 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    da93d6a View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    e315797 View commit details
    Browse the repository at this point in the history
  4. http: Consistent 'finish' event semantics

    In other Writable streams, the 'finish' event means that all of the data
    was written, and flushed to the underlying system.
    
    The 'prefinish' event means that end() was called, and all of the data
    was processed, but not necessarily completely flushed.
    
    This change brings the http OutgoingMessage classes more in sync with
    the other Writable classes throughout Node.
    
    Unfortunately, this change highlights an issue with http
    IncomingMessages, where the _dump() method will not actually pull the
    data off the wire.  This is a minor issue that is typically only
    relevant in test cases, and will be addressed in the next commit.
    isaacs committed Aug 15, 2013
    Copy the full SHA
    7c9b607 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    df23ce1 View commit details
    Browse the repository at this point in the history
  6. http: Prefer 'binary' over 'ascii'

    It's faster, because it doesn't have to check that each char is in the
    ASCII plane.
    isaacs committed Aug 15, 2013
    Copy the full SHA
    1f9f863 View commit details
    Browse the repository at this point in the history