spec: try to be more resilient to random timeouts

meh · meh · commit 9662c9b5404b · 2014-01-24T21:03:54.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -31,7 +31,7 @@ env:
     #- SELENIUM_BROWSER=ie SELENIUM_VERSION=6
     #- SELENIUM_BROWSER=ie SELENIUM_VERSION=7
     #- SELENIUM_BROWSER=ie SELENIUM_VERSION=8
-    - SELENIUM_BROWSER=ie SELENIUM_VERSION=9
+    #- SELENIUM_BROWSER=ie SELENIUM_VERSION=9
     - SELENIUM_BROWSER=ie SELENIUM_VERSION=10
     - SELENIUM_BROWSER=ie SELENIUM_VERSION=11
 
@@ -42,13 +42,9 @@ matrix:
     - env: SELENIUM_BROWSER=chrome SELENIUM_VERSION=31
     - env: SELENIUM_BROWSER=chrome SELENIUM_VERSION=30
 
-    - env: SELENIUM_BROWSER=opera SELENIUM_VERSION=12.15
-    - env: SELENIUM_BROWSER=opera SELENIUM_VERSION=12.16
-
     - env: SELENIUM_BROWSER=ie SELENIUM_VERSION=6
     - env: SELENIUM_BROWSER=ie SELENIUM_VERSION=7
     - env: SELENIUM_BROWSER=ie SELENIUM_VERSION=8
-    - env: SELENIUM_BROWSER=ie SELENIUM_VERSION=9
 
 before_install:
   - gem update bundler
diff --git a/spec/runner.rb b/spec/runner.rb
@@ -3,89 +3,97 @@
 require 'net/https'
 require 'json'
 
-loop do
-  uri           = URI.parse("https://www.browserstack.com/automate/plan.json")
-  agent         = Net::HTTP.new(uri.host, uri.port)
-  agent.use_ssl = true
-  request       = Net::HTTP::Get.new(uri.request_uri)
-  request.basic_auth(ENV['BS_USERNAME'], ENV['BS_AUTHKEY'])
+trials = 0
 
-  state = JSON.parse(agent.request(request).body)
+begin
+  loop do
+    uri           = URI.parse("https://www.browserstack.com/automate/plan.json")
+    agent         = Net::HTTP.new(uri.host, uri.port)
+    agent.use_ssl = true
+    request       = Net::HTTP::Get.new(uri.request_uri)
+    request.basic_auth(ENV['BS_USERNAME'], ENV['BS_AUTHKEY'])
 
-  if state["parallel_sessions_running"] < state["parallel_sessions_max_allowed"]
-    break
-  end
+    state = JSON.parse(agent.request(request).body)
 
-  print '.'
-  sleep 30
-end
+    if state["parallel_sessions_running"] < state["parallel_sessions_max_allowed"]
+      break
+    end
 
-puts "\rRunning specs..."
-puts
+    print '.'
+    sleep 30
+  end
 
-url = "http://#{ENV['BS_USERNAME']}:#{ENV['BS_AUTHKEY']}@hub.browserstack.com/wd/hub"
-cap = Selenium::WebDriver::Remote::Capabilities.new
+  puts "\rRunning specs..."
+  puts
 
-cap['platform']        = ENV['SELENIUM_PLATFORM'] || 'ANY'
-cap['browser']         = ENV['SELENIUM_BROWSER'] || 'chrome'
-cap['browser_version'] = ENV['SELENIUM_VERSION'] if ENV['SELENIUM_VERSION']
+  url = "http://#{ENV['BS_USERNAME']}:#{ENV['BS_AUTHKEY']}@hub.browserstack.com/wd/hub"
+  cap = Selenium::WebDriver::Remote::Capabilities.new
 
-cap['browserstack.tunnel'] = 'true'
-cap['browserstack.debug']  = 'false'
+  cap['platform']        = ENV['SELENIUM_PLATFORM'] || 'ANY'
+  cap['browser']         = ENV['SELENIUM_BROWSER'] || 'chrome'
+  cap['browser_version'] = ENV['SELENIUM_VERSION'] if ENV['SELENIUM_VERSION']
 
-browser = Selenium::WebDriver.for(:remote, url: url, desired_capabilities: cap)
-browser.navigate.to('http://localhost:9292')
+  cap['browserstack.tunnel'] = 'true'
+  cap['browserstack.debug']  = 'false'
 
-at_exit {
-  browser.quit
-}
+  browser = Selenium::WebDriver.for(:remote, url: url, desired_capabilities: cap)
+  browser.navigate.to('http://localhost:9292')
 
-begin
-  Selenium::WebDriver::Wait.new(timeout: 540, interval: 5) \
-    .until { not browser.find_element(:css, 'p#totals').text.strip.empty? }
+  at_exit {
+    browser.quit
+  }
 
-  totals   = browser.find_element(:css, 'p#totals').text
-  duration = browser.find_element(:css, 'p#duration').find_element(:css, 'strong').text
+  begin
+    Selenium::WebDriver::Wait.new(timeout: 120, interval: 5) \
+      .until { not browser.find_element(:css, 'p#totals').text.strip.empty? }
 
-  puts "#{totals} in #{duration}"
-  puts
+    totals   = browser.find_element(:css, 'p#totals').text
+    duration = browser.find_element(:css, 'p#duration').find_element(:css, 'strong').text
 
-  if totals =~ /0 failures/
-    exit 0
-  end
-
-  browser.find_elements(:css, '.example_group').slice_before {|x|
-    begin
-      x.find_element(:css, 'dd')
+    puts "#{totals} in #{duration}"
+    puts
 
-      false
-    rescue Exception
-      true
+    if totals =~ /0 failures/
+      exit 0
     end
-  }.each {|header, *specs|
-    next unless specs.any? { |x| x.find_element(:css, '.failed') rescue false }
 
-    namespace = header.find_element(:css, 'dt').text
+    browser.find_elements(:css, '.example_group').slice_before {|x|
+      begin
+        x.find_element(:css, 'dd')
+
+        false
+      rescue Exception
+        true
+      end
+    }.each {|header, *specs|
+      next unless specs.any? { |x| x.find_element(:css, '.failed') rescue false }
+
+      namespace = header.find_element(:css, 'dt').text
 
-    specs.each {|group|
-      next unless group.find_element(:css, '.failed') rescue false
+      specs.each {|group|
+        next unless group.find_element(:css, '.failed') rescue false
 
-      method = group.find_element(:css, 'dt').text
+        method = group.find_element(:css, 'dt').text
 
-      group.find_elements(:css, 'dd.example.failed').each {|el|
-        puts "#{namespace}#{method}"
-        puts "  #{el.find_element(:css, '.failed_spec_name').text}"
-        puts
-        puts el.find_element(:css, '.failure').text
-        puts
+        group.find_elements(:css, 'dd.example.failed').each {|el|
+          puts "#{namespace}#{method}"
+          puts "  #{el.find_element(:css, '.failed_spec_name').text}"
+          puts
+          puts el.find_element(:css, '.failure').text
+          puts
+        }
       }
     }
-  }
+  rescue Selenium::WebDriver::Error::NoSuchElementError
+    puts 'ya blew it'
+    puts browser.page_source
+  end
 rescue Selenium::WebDriver::Error::TimeOutError
-  puts "The specs timed out, some asynchronous spec must have failed, good luck with that."
-rescue Selenium::WebDriver::Error::NoSuchElementError
-  puts 'ya blew it'
-  puts browser.page_source
+  trials += 1
+
+  unless trials >= 4
+    retry
+  end
 end
 
 exit 1
