Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejitsu/require-analyzer
base: c802fea8c51e^
Choose a base ref
...
head repository: nodejitsu/require-analyzer
compare: e1aa6b0cac62
Choose a head ref
  • 6 commits
  • 4 files changed
  • 1 contributor

Commits on Sep 7, 2012

  1. use console.log instead of util.puts 

    also fixed some linting errors (semicolons & equals)
    @fb55
    fb55 committed Sep 7, 2012
    Copy the full SHA
    c802fea View commit details
    Browse the repository at this point in the history

  2. added a analyzer.path method that calls the appropriate function for … 

    …a path

as it's mainly the code of .analyze, use it there
    @fb55
    fb55 committed Sep 7, 2012
    Copy the full SHA
    5d32a73 View commit details
    Browse the repository at this point in the history

  3. use .path inside .dir (replaces findit)

    @fb55
    fb55 committed Sep 7, 2012
    Copy the full SHA
    e432496 View commit details
    Browse the repository at this point in the history

  4. removed findit from dependencies

    @fb55
    fb55 committed Sep 7, 2012
    Copy the full SHA
    b12e72d View commit details
    Browse the repository at this point in the history

  5. some minor changes 

    • use the `in` operator more frequently (it's much nicer than `typeof
foo !== "undefined"` + is more readable)
• removed some garbage
• added some comments
    @fb55
    fb55 committed Sep 7, 2012
    Copy the full SHA
    f74cfd3 View commit details
    Browse the repository at this point in the history

  6. removed two unnecessary functions 

    in L54, err would have always be falsey (or the function had returned
earlier)
    @fb55
    fb55 committed Sep 7, 2012
    Copy the full SHA
    e1aa6b0 View commit details
    Browse the repository at this point in the history