This repository has been archived by the owner on May 29, 2019. It is now read-only.
Added support for popover-html directive for binding html #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I need to clean this up some - I would like some comments on the caveats. I probably did not implement it in a good way here. Edit: Looks like I figured out a better implementation, by offering an optional flag in the |
Modified tooltip to support new popoverHtml Readded forgotten fix to prefix for popover-html Switched to correct unsafe html binding directive Refactored and added a flag that can be passed as an optional fourth value in $tooltip for unsafe html binding Fix spec Returned template setting to original location Removed extra whitespace Condensed test to one meaningful test of rendering properly Changed the test Fix up test Hopefully the true test fix Removed extra check
|
I think #1848 is a cleaner implementation, I will defer to that PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The popover component in Bootstrap supports using html as your content. This proposed fix creates a new directive,
popoverHtmlto support this new behavior. You can observe this directive at work here.It modifies the tooltip script to conditionally choose the template used depending on whether an optional fourth flag is true.
There is a caveat of some code duplication due to reusing most of the HTML from the current popover directive.
It may not be the ideal implementation, and would like thoughts on this. However, I believe that it would be ideal to try to offer this capability for popovers, simply since the current non-support is a regression.