Skip to content

Commit 2b7ca68

Browse files
committedDec 12, 2014
Cleanup
* Remove unused variables * Fix wearing out of screwdriver * Move magic numbers into constants * Scale down texture
1 parent bd24c15 commit 2b7ca68

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed
 

Diff for: ‎mods/screwdriver/init.lua

+11-12
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,17 @@ local function nextrange(x, max)
66
return x
77
end
88

9+
local ROTATE_FACE = 1
10+
local ROTATE_AXIS = 2
11+
local USES = 10
12+
913
-- Handles rotation
1014
local function screwdriver_handler(itemstack, user, pointed_thing, mode)
1115
if pointed_thing.type ~= "node" then
1216
return
1317
end
1418

1519
local pos = pointed_thing.under
16-
local keys = user:get_player_control()
17-
local player_name = user:get_player_name()
1820

1921
if minetest.is_protected(pos, user:get_player_name()) then
2022
minetest.record_protection_violation(pos, user:get_player_name())
@@ -34,22 +36,19 @@ local function screwdriver_handler(itemstack, user, pointed_thing, mode)
3436
local n = node.param2
3537
local axisdir = math.floor(n / 4)
3638
local rotation = n - axisdir * 4
37-
if mode == 1 then
39+
if mode == ROTATE_FACE then
3840
n = axisdir * 4 + nextrange(rotation, 3)
39-
elseif mode == 3 then
41+
elseif mode == ROTATE_AXIS then
4042
n = nextrange(axisdir, 5) * 4
4143
end
4244

4345
node.param2 = n
4446
minetest.swap_node(pos, node)
4547

46-
local item_wear = tonumber(itemstack:get_wear())
47-
item_wear = item_wear + 300 -- was 327
48-
if item_wear > 65535 then
49-
itemstack:clear()
50-
return itemstack
48+
if not minetest.setting_getbool("creative_mode") then
49+
itemstack:add_wear(65535 / (USES - 1))
5150
end
52-
itemstack:set_wear(item_wear)
51+
5352
return itemstack
5453
end
5554

@@ -58,11 +57,11 @@ minetest.register_tool("screwdriver:screwdriver", {
5857
description = "Screwdriver (left-click rotates face, right-click rotates axis)",
5958
inventory_image = "screwdriver.png",
6059
on_use = function(itemstack, user, pointed_thing)
61-
screwdriver_handler(itemstack, user, pointed_thing, 1)
60+
screwdriver_handler(itemstack, user, pointed_thing, ROTATE_FACE)
6261
return itemstack
6362
end,
6463
on_place = function(itemstack, user, pointed_thing)
65-
screwdriver_handler(itemstack, user, pointed_thing, 3)
64+
screwdriver_handler(itemstack, user, pointed_thing, ROTATE_AXIS)
6665
return itemstack
6766
end,
6867
})

Diff for: ‎mods/screwdriver/textures/screwdriver.png

-25 Bytes
Loading

0 commit comments

Comments
 (0)
Please sign in to comment.