Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-3405 // Automated Error Report: ModuleException: dwr-modules.xml file doesn't exist. #789

Merged
merged 1 commit into from Mar 19, 2014

Conversation

ujjwalarora
Copy link
Member

https://tickets.openmrs.org/browse/TRUNK-3405

Bug Solved and 2 Unit tests added

@ujjwalarora
Copy link
Member Author

The logic behind my solution is that whenever dwr-modules.xml file is not found, a function creates it using DOM before its used further in WebModuleUtil.java, and hence its very well recognized by the XML parser and new module information is written into it.

@ujjwalarora
Copy link
Member Author

Steps to Test :

//Unit Tests
1.) The first 2 unit tests are added for the purpose in WebModuleUtilTest.java

//Manually
1.) Delete the dwr-modules.xml from /webapps/openmrs/WEB-INF/dwr-modules.xml.
2.) Try to add/delete a module
3.) New dwr-modules.xml file would be created with the module info

…java

+ added 2 unit tests in webModuleUtilTest.java

back to 745 - due to stashing

Added break statement on line 106 of webmoduleUtilTest.java

TRUNK-3405 - minor changes

TRUNK-3405 - removed unnecessary lines

TRUNK-3405 - added function getRealPath()
dkayiwa added a commit that referenced this pull request Mar 19, 2014
TRUNK-3405 // Automated Error Report: ModuleException: dwr-modules.xml file doesn't exist.
@dkayiwa dkayiwa merged commit 8541954 into openmrs:master Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants