better tests for Mojo::IOLoop::Delay

mojolicious · Apr 4, 2013 · 14fafc6 · 14fafc6
1 parent 0cb328d
commit 14fafc6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/Mojo/IOLoop/Delay.pm b/lib/Mojo/IOLoop/Delay.pm
@@ -118,7 +118,7 @@ emit the following new ones.
     ...
   });
 
-Emitted once the active event counter reaches zero or there are no more steps.
+Emitted once the active event counter reaches zero.
 
 =head1 ATTRIBUTES
 

diff --git a/t/mojo/delay.t b/t/mojo/delay.t
@@ -79,21 +79,23 @@ is $finished, 1,         'finish event has been emitted once';
 is $result,   'success', 'right result';
 
 # End chain after second step
+my $remaining;
 ($finished, $result) = ();
 $delay = Mojo::IOLoop::Delay->new;
 $delay->on(finish => sub { $finished++ });
 $delay->steps(
   sub { Mojo::IOLoop->timer(0 => shift->begin) },
   sub {
-    $result = 'success';
-    shift->begin->();
+    $result    = 'success';
+    $remaining = shift->begin->();
   },
   sub { $result = 'fail' },
   sub { $result = 'fail' }
 );
 $delay->wait;
-is $finished, 1,         'finish event has been emitted once';
-is $result,   'success', 'right result';
+is $remaining, 0,         'none remaining';
+is $finished,  1,         'finish event has been emitted once';
+is $result,    'success', 'right result';
 
 # Finish steps with event
 $result = undef;