Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 92875501d23c
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 885142a5edc2
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 14, 2014

  1. src: fix _XOPEN_SOURCE redefinition warning 

    Fix the following compiler warning on systems where _XOPEN_SOURCE is
defined by default:

    ../src/node_constants.cc:35:0: warning: "_XOPEN_SOURCE" redefined
     #define _XOPEN_SOURCE 500

Move the (re)definition of _XOPEN_SOURCE to the top of the file while
we're here.  Commit 00890e4 adds a `#define _XOPEN_SOURCE 500` in order
to make <fcntl.h> expose O_NONBLOCK but it does so after other system
headers have been included.  If those headers include <fcntl.h>, then
the #include in node_constants.cc will be a no-op and O_NONBLOCK won't
be visible.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed May 14, 2014
    Copy the full SHA
    885142a View commit details
    Browse the repository at this point in the history