fixed small attribute extraction bug in Mojo::DOM

mojolicious · Jul 3, 2012 · 946d2c2 · 946d2c2
1 parent 102567b
commit 946d2c2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -6,7 +6,7 @@
   - Improved documentation.
   - Improved tests.
   - Fixed JSON Pointer escaping.
-  - Fixed small text extraction bug in Mojo::DOM.
+  - Fixed small text and attribute extraction bug in Mojo::DOM.
   - Fixed small inconsistency between routes and static dispatchers.
 
 3.01  2012-07-01

diff --git a/lib/Mojo/DOM.pm b/lib/Mojo/DOM.pm
@@ -64,7 +64,7 @@ sub attrs {
   return $attrs unless @_;
 
   # Get
-  return $attrs->{$_[0]} unless @_ > 1 || ref $_[0];
+  return $attrs->{$_[0]} // '' unless @_ > 1 || ref $_[0];
 
   # Set
   %$attrs = (%$attrs, %{ref $_[0] ? $_[0] : {@_}});

diff --git a/t/mojo/dom.t b/t/mojo/dom.t
@@ -438,9 +438,9 @@ is $dom->at('ook'),     undef, 'no result';
 is $dom->at('[xmlns\:bk]')->{'xmlns:bk'}, 'uri:book-ns', 'right attribute';
 is $dom->at('[bk]')->{'xmlns:bk'},        'uri:book-ns', 'right attribute';
 is $dom->at('[bk]')->attrs('xmlns:bk'), 'uri:book-ns', 'right attribute';
-is $dom->at('[bk]')->attrs('s:bk'),     undef,         'no attribute';
-is $dom->at('[bk]')->attrs('bk'),       undef,         'no attribute';
-is $dom->at('[bk]')->attrs('k'),        undef,         'no attribute';
+is $dom->at('[bk]')->attrs('s:bk'),     '',            'no attribute';
+is $dom->at('[bk]')->attrs('bk'),       '',            'no attribute';
+is $dom->at('[bk]')->attrs('k'),        '',            'no attribute';
 is $dom->at('[s\:bk]'), undef, 'no result';
 is $dom->at('[k]'),     undef, 'no result';