-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRuby Complete 1.7.16.1 does not move asm to other package #2219
Comments
looks like all 1.7.14, 1.7.15, 1.7.16 and 1.7.16.1 have this regression :( |
@hendriks73 if your setup is OK with a more modular "jruby" you can use org.jruby:jruby-noasm:1.7.16.1 which declares all dependencies BUT not asm and includes the repackaged ASM classes packed |
let's see if I can get a test case for this . . . |
Thanks for the jruby-noasm hint - works for me (as I don't mind multiple jars). |
Definitely need to fix the renaming. |
how can I trigger "ASM" to test the case with jruby running along side asm 2.2.3 ? the fix is there but a test case to avoid regression would nice. |
Can't you just make sure asm 2.2.3 is in the classpath and lookup the URLs Or the other way around: With only jruby-complete in the classpath, you shouldn't be able to load the class |
…ge name rounding up and fixes #2219
testing now on missing thanx @hendriks73 |
I'm impressed, how quickly you were able to fix this! |
it also excludes the asm and com.github.jnr:jnr-ffi from dependencies list so the BND for packaging the osgi does not include those anymore
…ge name rounding up and fixes jruby#2219
Up to at least JRuby Complete 1.7.13 the asm classes were moved to a package that was not the original package (which is
org.objectweb.asm
). This prevented version clashes when used with other script engines like jython or even with older versions of Hibernate orcom.intellij:forms_rt
. In short: It allowed to use JRuby in an environment that also needs other versions of asm.1.7.14 and 1.7.15 apparently were pretty unusable, declaring dependencies or missing files.
Now JRuby Complete 1.7.16.1 could work again, but unfortunately contains an original asm v4 library without renamed package. This leads to version clashes with asm 2.2.3, which is still used widely.
Please revert to renaming the package name of asm (and I guess other libraries—not sure what else is included that may clash) to something custom and only used in JRuby, so that the library is embeddable again in non-trivial systems.
Thanks!
The text was updated successfully, but these errors were encountered: