Add tombstone for move #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,8 +177,17 @@ public Response moveObject(@HeaderParam("Destination") final String destinationU | |||
| throw new ClientErrorException("Destination resource already exists", PRECONDITION_FAILED); | |||
| } | |||
|
|
|||
| final FedoraResource srcResource = nodeService.find(session, source); | |||
| final Node sourceNode = srcResource.getNode(); | |||
There was a problem hiding this comment.
We want to avoid dealing directly with JCR nodes at the fcrepo-http-api level.
Additionally, if the request to move a resource comes directly against the NodeService, we also want a tombstone to be created, i.e. tombstones are not something that only need to be created when a invocation comes through the REST-API.
I would suggest moving the tombstone creation logic into NodeService.moveObject().
There was a problem hiding this comment.
Just to be clear about the scope in which JCR is a presence: we want to avoid dealing directly with JCR nodes anywhere except -kernel-impl. Admittedly, that's an ideal, but it's the mark against which we should be measuring.
|
Resolved with: 58676ec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.