Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'improve-luacontroller'
However, without the print_count limiting functionality Conflicts: mesecons_luacontroller/init.lua
- Loading branch information
Showing
2 changed files
with
425 additions
and
371 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,30 @@ | ||
| -- Ugly hack to prevent breaking compatibility with other mods | ||
| -- Just remove the following two functions to delete the hack, to be done when other mods have updated | ||
| function mesecon.receptor_on(self, pos, rules) | ||
| if (self.receptor_on) then | ||
| print("[Mesecons] Warning: A mod with mesecon support called mesecon:receptor_on.") | ||
| print("[Mesecons] If you are the programmer of this mod, please update it ") | ||
| print("[Mesecons] to use mesecon.receptor_on instead. mesecon:* is deprecated") | ||
| print("[Mesecons] Otherwise, please make sure you're running the latest version") | ||
| print("[Mesecons] of that mod and inform the mod creator.") | ||
| else | ||
| rules = pos | ||
| pos = self | ||
| end | ||
| mesecon.queue:add_action(pos, "receptor_on", {rules}, nil, rules) | ||
| end | ||
|
|
||
| function mesecon.receptor_off(self, pos, rules) | ||
| if (self.receptor_off) then | ||
| print("[Mesecons] Warning: A mod with mesecon support called mesecon:receptor_off.") | ||
| print("[Mesecons] If you are the programmer of this mod, please update it ") | ||
| print("[Mesecons] to use mesecon.receptor_off instead. mesecon:* is deprecated") | ||
| print("[Mesecons] Otherwise, please make sure you're running the latest version") | ||
| print("[Mesecons] of that mod and inform the mod creator.") | ||
| else | ||
| rules = pos | ||
| pos = self | ||
| end | ||
| mesecon.queue:add_action(pos, "receptor_off", {rules}, nil, rules) | ||
| end | ||
| -- Ugly hack to prevent breaking compatibility with other mods | ||
| -- Just remove the following two functions to delete the hack, to be done when other mods have updated | ||
| function mesecon.receptor_on(self, pos, rules) | ||
| if (self.receptor_on) then | ||
| print("[Mesecons] Warning: A mod with mesecon support called mesecon:receptor_on.") | ||
| print("[Mesecons] If you are the programmer of this mod, please update it ") | ||
| print("[Mesecons] to use mesecon.receptor_on instead. mesecon:* is deprecated") | ||
| print("[Mesecons] Otherwise, please make sure you're running the latest version") | ||
| print("[Mesecons] of that mod and inform the mod creator.") | ||
| else | ||
| rules = pos | ||
| pos = self | ||
| end | ||
| mesecon.queue:add_action(pos, "receptor_on", {rules}, nil, rules) | ||
| end | ||
|
|
||
| function mesecon.receptor_off(self, pos, rules) | ||
| if (self.receptor_off) then | ||
| print("[Mesecons] Warning: A mod with mesecon support called mesecon:receptor_off.") | ||
| print("[Mesecons] If you are the programmer of this mod, please update it ") | ||
| print("[Mesecons] to use mesecon.receptor_off instead. mesecon:* is deprecated") | ||
| print("[Mesecons] Otherwise, please make sure you're running the latest version") | ||
| print("[Mesecons] of that mod and inform the mod creator.") | ||
| else | ||
| rules = pos | ||
| pos = self | ||
| end | ||
| mesecon.queue:add_action(pos, "receptor_off", {rules}, nil, rules) | ||
| end | ||
|
|
Oops, something went wrong.
4bd9d2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the anti-flood feature removed?
4bd9d2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because you might want to have debug output when playing locally and because there is a problem in the logic of it:
If you suppress output, this behaviour is unexpected and needs to be explained to the user. Therefore, there has to be a log message saying that flooding is prevented and where this can be changed. This debug message, however, floods the console just as well. So it didn't actually make a difference.
The idea was pretty good, but I don't see a sane way to implement it so that server consoles won't be flooded and that print behaviour still is logical. The recommended way for server owners that want to prevent flooding is to just completely remove the print() command, users can't see that output anyways.