Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flatiron/director
base: 8d40862ae127
Choose a base ref
...
head repository: flatiron/director
compare: 234c82e7c8f4
Choose a head ref
  • 4 commits
  • 9 files changed
  • 2 contributors

Commits on Jul 26, 2012

  1. Remove adhoc test since it is broken and seems very outdated.

    @domenic
    domenic committed Jul 26, 2012
    Copy the full SHA
    4821a53 View commit details
    Browse the repository at this point in the history

  2. Use path instead of string concatentation. 

    More Windows-friendly.
    @domenic
    domenic committed Jul 26, 2012
    Copy the full SHA
    1c3fb5a View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2012

  1. Clean up tests; use QUnit from npm. 

    * The qunitjs package from npm helps us avoid bundling jQuery/QUnit.
* The markup was a mess, containing lots of unnecessary QUnit elements, type attributes, etc.
* Had to update the route matcher to handle more than one level deep of files.
    @domenic
    domenic committed Jul 27, 2012
    Copy the full SHA
    f538cdd View commit details
    Browse the repository at this point in the history

  2. Merge pull request #128 from domenic/tests 

    Partially fix browser tests
    @pksunkara
    pksunkara committed Jul 27, 2012
    Copy the full SHA
    234c82e View commit details
    Browse the repository at this point in the history