Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joyent/libuv
base: 429bb804ed26
Choose a base ref
...
head repository: joyent/libuv
compare: a1e159f04ec8
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 8, 2013

  1. test: relax TTY availability assumptions 

    test-tty.c currently assumes that a TTY is available to the test runner,
and fails hard if not. This may not be true on some autobuilding
environment, making the build fail as shown in [0].
Instead, let's properly skip the test in such cases.

[0] http://ur1.ca/fr5bd

Signed-off-by: Luca Bruno <lucab@debian.org>
    @lucab @bnoordhuis
    lucab authored and bnoordhuis committed Oct 8, 2013
    Copy the full SHA
    6462eaf View commit details
    Browse the repository at this point in the history

  2. test: relax timing assumption of loop_stop 

    The loop_stop test makes an implicit assumption about the triggering
timing of a repeating trigger, which may not hold true on slower or
virtualized machines, thus failing the test as shown at [0] and
discussed at [1].
This commit relaxes the assumption, without mandating the exact number
of runs.

[0] http://ur1.ca/fr5bw
[1] https://groups.google.com/d/msg/libuv/5-fNIC7hIAo/yqznDmwHDAIJ

Signed-off-by: Luca Bruno <lucab@debian.org>
    @lucab @bnoordhuis
    lucab authored and bnoordhuis committed Oct 8, 2013
    Copy the full SHA
    bddf357 View commit details
    Browse the repository at this point in the history

  3. test: relax timing assumption of timer_again 

    timer_again test makes an implicit assumption on the triggering
timing of a repeating timer. However, this assumption may be not
true on slower or virtualized architecture due to delay accumulation,
which may fail the test as show in [0].
This commit makes explicit checks conforming to the asserted behavior.

[0] http://ur1.ca/fr5c4

Signed-off-by: Luca Bruno <lucab@debian.org>
    @lucab @bnoordhuis
    lucab authored and bnoordhuis committed Oct 8, 2013
    Copy the full SHA
    a1e159f View commit details
    Browse the repository at this point in the history