Getting baseURL for JMS messages from event user data field, which is set using by HTTP API from UriInfo baseURL #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set using by HTTP API from UriInfo baseURL
| **/ | ||
| private void init( final UriInfo uriInfo ) { | ||
| if ( !baseURLSet ) { | ||
| baseURLSet = true; |
There was a problem hiding this comment.
Move "baseURLSet = true" to the end of the "try" block in case an exception is thrown.
There was a problem hiding this comment.
Because this will be triggered with each update to the repository, my thinking was that it should fail as quickly as possible. If an exception is thrown in the try block, it's likely going to happen every time and the baseURL would never be set successfully. So my thinking was to try once and then not retry if it doesn't work.
There was a problem hiding this comment.
Sounds reasonable, @escowles. Could you please add a comment in the code that explains that, since the logic is slightly different than the natural flow.
|
Resolved with: ae12d03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://www.pivotaltracker.com/story/show/72351918