Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joyent/libuv
base: eee4776549f4
Choose a base ref
...
head repository: joyent/libuv
compare: 6c6c9221679c
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jun 7, 2014

  1. unix, windows: make uv_barrier_wait() return bool 

    Make uv_barrier_wait() return a boolean value indicating whether this
thread was the "serializer".

From `man pthread_barrier_wait`:

    Upon successful completion, the pthread_barrier_wait() function
    shall return PTHREAD_BARRIER_SERIAL_THREAD for a single (arbitrary)
    thread synchronized at the barrier and zero for each of the other
    threads.

Exposing that information from libuv is useful because it can make
cleanup significantly easier:

    if (uv_barrier_wait(&barrier) > 0)
      uv_barrier_destroy(&barrier);

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed Jun 7, 2014
    Copy the full SHA
    91985d4 View commit details
    Browse the repository at this point in the history

  2. include: document barrier functions 

    Add some basic doc comments to the uv_barrier_*() functions and document
the "serializer" return value from the previous commit.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed Jun 7, 2014
    Copy the full SHA
    b64c359 View commit details
    Browse the repository at this point in the history

  3. test: make barrier test more rigorous 

    A correct barriers implementation blocks in uv_barrier_destroy() until
the last thread returns from uv_barrier_wait() so make the test more
rigorous by destroying the barrier straight away instead of first
joining the worker thread.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed Jun 7, 2014
    Copy the full SHA
    6c6c922 View commit details
    Browse the repository at this point in the history