Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joyent/libuv
base: b5fc9444b127
Choose a base ref
...
head repository: joyent/libuv
compare: 0ddf9d6b98c3
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 4, 2012

  1. Revert "unix: reopen tty as /dev/tty"

    This reverts commit 31f9fbc.
    
    The reverted commit depends on commit 5da380a ("use select() for specific fds
    on OS X") which polls /dev/tty file descriptors in a separate thread to work
    around deficiencies in the kqueue API on OS X.
    
    Unfortunately, 5da380a has a bug that effectively makes the select() thread
    busy-loop. Revert this commit for now.
    bnoordhuis committed Nov 4, 2012
    5
    Copy the full SHA
    20bb1bf View commit details
    Browse the repository at this point in the history
  2. Revert "unix: use select() for specific fds on OS X"

    This reverts commit 5da380a.
    
    Contains a bug that effectively makes the select() thread busy-loop. The file
    descriptor is polled for both reading and writing, regardless of what events
    the main thread wants to receive. Fixing that requires proper synchronization
    between the two threads.
    
    See #614.
    bnoordhuis committed Nov 4, 2012
    Copy the full SHA
    0ddf9d6 View commit details
    Browse the repository at this point in the history