TRUNK-4126 Add duration and durationUnits properties to DrugOrder class #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Returns concept when given a piece of text | ||
| */ | ||
| public Concept returnConceptForEntryOfDurationUnits(Concept concept) { |
There was a problem hiding this comment.
This needs to be a utility function somewhere else outside the concept class, how about you move it to OrderUtil? I think it needs to be static and should return a conceptId and not a concept really
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
This PR updates the Migration Guide docs as follows: - Renames the sidebar entry for the `Migration Guide` from `Migration Guide: React 18` to `Migration Guide` to signify the broadened scope of the guide. - Updates the guide to show information about migrating Jest, Testing Library React and userEvent to their latest versions. - Reorganizes information from the `specifics` section into a `Preamble` and a comprehensive `Dependencies` section. Work to come: - Add specific guidance on how to migrate to the newest versions of Jest, Testing Library React and userEvent. Co-authored-by: Brandon Istenes <bistenes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-4126 some pending work of fixing a test failure that am dealing with