fs: fix infinite loop in fs.readFileSync()

Fix an infinite loop in the case where the file got truncated by a concurrent writer while fs.readFileSync() was busy reading in the file.
nodejs · Jun 12, 2012 · e6c4619 · e6c4619
1 parent 8f1aaee
commit e6c4619
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -219,12 +219,7 @@ fs.readFileSync = function(path, encoding) {
     }
 
     pos += bytesRead;
-
-    if (size !== 0) {
-      done = pos >= size;
-    } else {
-      done = bytesRead >= 0;
-    }
+    done = (bytesRead === 0) || (size !== 0 && pos >= size);
   }
 
   fs.closeSync(fd);