Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: 25f2af8
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: ce56bd5
Choose a head ref
  • 4 commits
  • 6 files changed
  • 1 contributor

Commits on Oct 21, 2011

  1. Correct naming of attachments column 

    Commit 97b67e4 introduced some changes to the
BugData class: the 'attachment' column was renamed to 'attachment_count'. This
change was not cascaded everywhere, which resulted in the column not being
displayed by default (as the now-invalid column named 'attachment' was
automatically removed)

This then hid the fact that $g_show_attachment_indicator was actually not
working as advertised, i.e. the attachments column is always displayed; when
ON the field contains the paperclip bitmap, and when OFF the actual number of
attachments for the corresponding issue.

Affects issue #13276

This is porting d86ba72 to master
    @dregad
    dregad committed Oct 21, 2011
    Copy the full SHA
    d5a0ea7 View commit details
    Browse the repository at this point in the history

  2. Update list of standard columns in config_defaults_inc.php 

    The list now matches what is actually available in the manage columns pages

Porting ad006ff to master
    @dregad
    dregad committed Oct 21, 2011
    Copy the full SHA
    a143371 View commit details
    Browse the repository at this point in the history

  3. Removed obsolete comment 

    file_can_view_bug_attachments does check for allow_view_own_attachments
    @dregad
    dregad committed Oct 21, 2011
    Copy the full SHA
    791b936 View commit details
    Browse the repository at this point in the history

  4. Obsolete $g_show_attachment_indicator option 

    Following discussion with dhx on IRC on 31-Aug-2011, this setting is
not necessary.

There is no point or advantage in displaying a paperclip bitmap as opposed to
the actual number of attachments; furthermore, the option was inconsistently
used, in one instance it was actually hiding the attachments column completely

Affects issue #13276

Porting 3323204 to master
    @dregad
    dregad committed Oct 21, 2011
    Copy the full SHA
    ce56bd5 View commit details
    Browse the repository at this point in the history