build: always compile with large file support

Fixes a nasty sizeof(struct stat) mismatch bug that caused random crashes and silent memory corruption.
nodejs · Nov 30, 2011 · bbd976b · bbd976b
1 parent eda1538
commit bbd976b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/common.gypi b/common.gypi
@@ -109,6 +109,11 @@
           'BUILDING_V8_SHARED=1',
           'BUILDING_UV_SHARED=1',
         ],
+      }, {
+        'defines': [
+          '_LARGEFILE_SOURCE',
+          '_FILE_OFFSET_BITS=64',
+        ],
       }],
       [ 'OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris"', {
         'cflags': [ '-Wall', '-pthread', ],
@@ -128,7 +133,6 @@
         ],
       }],
       ['OS=="mac"', {
-        'defines': ['__DARWIN_64_BIT_INO_T=1'],
         'xcode_settings': {
           'ALWAYS_SEARCH_USER_PATHS': 'NO',
           'GCC_CW_ASM_SYNTAX': 'NO',                # No -fasm-blocks

diff --git a/deps/uv/uv.gyp b/deps/uv/uv.gyp
@@ -3,15 +3,10 @@
     'conditions': [
       ['OS != "win"', {
         'defines': [
-          '_LARGEFILE_SOURCE',
-          '_FILE_OFFSET_BITS=64',
           '_GNU_SOURCE',
           'EIO_STACKSIZE=262144'
         ],
         'conditions': [
-          ['OS=="mac"', {
-            'defines': ['__DARWIN_64_BIT_INO_T=1'],
-          }],
           ['OS=="solaris"', {
             'cflags': ['-pthreads'],
             'ldlags': ['-pthreads'],

diff --git a/node.gyp b/node.gyp
@@ -124,8 +124,6 @@
       'defines': [
         'ARCH="<(target_arch)"',
         'PLATFORM="<(OS)"',
-        '_LARGEFILE_SOURCE',
-        '_FILE_OFFSET_BITS=64',
       ],
 
       'conditions': [