Skip to content

Commit

Permalink
Revert "add rel=author links to Google+ to pod and release pages in o…
Browse files Browse the repository at this point in the history
…rder to provide Author information to Google"

This reverts commit 7c8b1d6.

I'm reverting this commit because it's a bit controversial.  The
following problems:

1) We already have the "plus" icon on author pages, so this duplicates
the image.

2) There has been some concern that this places Google in a more
prominent position than other search engines for no apparent gain.

3) It's not clear (to me) what the real difference between rel="me" and
rel="author" is.  Probably we should decide on how we want to handle
that and then do it without adding an extra image.

We do have the Coderwall endorse button under author images where
appropriate, but that button serves a different purpose and it also
relays some info about the author.

So, I think that with this particular commit, we'd just need some more
discussion as to whether it's really needed and how best to implement
it.
  • Loading branch information
oalders committed Jan 22, 2014
1 parent bdd1b84 commit 347471a
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions root/inc/author-pic.html
Expand Up @@ -11,10 +11,5 @@
width="110" height="20"
src="https://api.coderwall.com/<% p.id %>/endorsecount.png" /></a></div>
<% END %>
<% IF p.name == "googleplus" %>
<a rel="author" href="<% profiles.${p.name}.url.replace('%s', p.id) %>?rel=author" target="_blank" title="<% p.name %> - <% p.id%>">
<img src="/static/images/profile/<% p.name %>.png" width=16 height=16 alt="<% p.name %>">
</a>
<% END %>
<% END %>
</div>

10 comments on commit 347471a

@monken
Copy link
Contributor

@monken monken commented on 347471a Jan 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capture
Afaik, this was necessary for showing the author in the Google search. Otherwise Google won't be able to establish that connection.

@szabgab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the link to the g+ page of the author with ?rel=author attached is needed for the author image to show up on Google.
https://support.google.com/webmasters/answer/1408986?hl=en

It does not need to be a G+ button it can be a simple link, probably even a 1-dot image linked to G+. Google has a tool to check after this
is implemented if the small link is enough.
In addition, the code could be a bit more clever to add this other button only when the other one is not on the page.

@oalders
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My confusion is about rel="me" and rel="author". On the author page, for example, we already have:

<a rel="me" href="http://plus.google.com/+DavidGoldenXdg" target="_blank" title="googleplus - +DavidGoldenXdg">
  <img src="/static/images/profile/googleplus.png" width=16 height=16 alt="googleplus">
</a>

Do we need to change the G+ rel to author rather than me?

I see that reverting the patch removes the rel from /pod, so we need to add that back. The 1x1 transparent dot seems like a good way to go for this, assuming that's good enough for google.

@monken
Copy link
Contributor

@monken monken commented on 347471a Jan 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rel="me" means that this is the page of the author, rel="author" means that this link forwards to the page of the author.
We might as well just add a display: none stylesheet to the link on the /pod page. Should do the trick. Google won't mind. It's just semantics.

@rwstauner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly was this attempting to solve?
We already had the author images in google search results.

We have rel="me" on the author page (803a88c) and rel="author" on the links to the author page (87a971b).

Reading that google answer link it sounds like the rules have changed (but the old way worked for some people at least),
so maybe that's the problem.

@szabgab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author images started to show up after the rel="author" links were added.

I am not aware of any changes in the rules on how to connect articles to Google author information.

@rwstauner
Copy link
Contributor

@rwstauner rwstauner commented on 347471a Jan 22, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oalders
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing icons before this as well. I think it's just a matter of knowing why we are doing X as opposed to Y and then hiding links either with the dot or CSS.

@szabgab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think these rel=author links are not necessary then, remove them, and then we can see what happens.
I am not attached to them.

@oalders
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ioncache is about to push a commit that restores and hides the links.

Please sign in to comment.