fixed small memory leak in Mojo::IOLoop::Stream

mojolicious · Dec 19, 2011 · 5fcc030 · 5fcc030
1 parent fb56c7b
commit 5fcc030
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Changes b/Changes
@@ -1,9 +1,10 @@
 This file documents the revision history for Perl extension Mojolicious.
 
-2.39    2011-12-19 00:00:00
+2.39    2011-12-20 00:00:00
         - Added EXPERIMENTAL close method to Mojo::IOLoop::Stream.
         - Improved documentation. (marcus, vervain, sri)
         - Fixed small argument bug in client method of Mojo::IOLoop.
+        - Fixed small memory leak in Mojo::IOLoop::Stream.
 
 2.38    2011-12-17 00:00:00
         - Changed Mojo::IOLoop->client arguments from ($loop, $stream, $err)

diff --git a/lib/Mojo/IOLoop/Stream.pm b/lib/Mojo/IOLoop/Stream.pm
@@ -25,10 +25,10 @@ sub close {
   my $self = shift;
 
   # Cleanup
-  return unless my $handle  = delete $self->{handle};
   return unless my $watcher = $self->{iowatcher};
-  $watcher->drop_handle($handle);
   $watcher->drop_timer(delete $self->{timer}) if $self->{timer};
+  return unless my $handle = delete $self->{handle};
+  $watcher->drop_handle($handle);
 
   # Close
   close $handle;