Skip to content
This repository has been archived by the owner on Nov 30, 2017. It is now read-only.

Cleanup and simplify roles #152

Merged
merged 1 commit into from
Dec 12, 2013
Merged

Conversation

dwradcliffe
Copy link
Member

This shouldn't cause any changes on the servers.

@brandonparsons
Copy link

Hi there,

I watch this repo for the sole purpose of learning about Chef, and server administration in general. Thanks for keeping it open!

I'm just wondering what drove this change. Do you find it easier to manage with a single base role, rather than separate roles for logging, mailer etc.?

@dwradcliffe
Copy link
Member Author

@brandonparsons Couple reasons: First of all we're not using any of those roles outside of the base role, so there's no real reason to split them out. Keeping things simple without sacrificing functionality should always be our goal. Also, as we move to chef-server (very soon!), roles are not versioned so simplifying and reducing role usage is generally suggested.

@brandonparsons
Copy link

Cool - thanks for the explanation :)

@skottler
Copy link
Member

@dwradcliffe LGMT - I'll need to upload these changes to the chef server, too.

skottler pushed a commit that referenced this pull request Dec 12, 2013
@skottler skottler merged commit e918719 into rubygems:master Dec 12, 2013
@dwradcliffe dwradcliffe deleted the simplify-roles branch December 12, 2013 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants