Add back the <span> around the favorites count

Tests and, more importantly, JS which updates the count relies on the <span>. Keeping it necessitates adjusting CSS to preserve font-weight.
metacpan · Feb 3, 2014 · 8997d07 · 8997d07
1 parent 4169acb
commit 8997d07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/root/inc/favorite.html b/root/inc/favorite.html
@@ -4,8 +4,8 @@
     <input type="hidden" name="release" value="<% module.release || module.name %>">
     <input type="hidden" name="author" value="<% module.author %>">
     <input type="hidden" name="distribution" value="<% module.distribution %>">
-<button type="submit" class="favorite<% IF module.favorites || release.favorites %> highlight<% END %><% IF module.myfavorite %> active<% END %>"><% module.favorites || release.favorites %> ++</button>
+    <button type="submit" class="favorite<% IF module.favorites || release.favorites %> highlight<% END %><% IF module.myfavorite %> active<% END %>"><span><% module.favorites || release.favorites %></span> ++</button>
 </form>
 <% ELSE -%>
-<a href="" onclick="alert('Please sign in to add favorites'); return false" class="favorite<% IF module.favorites || release.favorites %> highlight<% END %>">
-<% module.favorites || release.favorites %> ++</a><% END -%>
+<a href="" onclick="alert('Please sign in to add favorites'); return false" class="favorite<% IF module.favorites || release.favorites %> highlight<% END %>"><span>
+<% module.favorites || release.favorites %></span> ++</a><% END -%>
diff --git a/root/static/css/style.css b/root/static/css/style.css
@@ -96,6 +96,10 @@ button.favorite, a.favorite {
     font-weight: normal;
 }
 
+.breadcrumbs .favorite span {
+    font-weight: normal;
+}
+
 button.favorite {
     min-width: 35px;
     cursor: pointer;