The Obs.hbm.xml file has this already:

I believe that sets a batch-size of 25 for all fetches of obs, therefore the changes you're proposing here will have no effect. (Is that right?)

batch-size at the class level has no effect on collections. it has to be set explicitly on collections.

http://docs.jboss.org/hibernate/orm/3.3/reference/en/html/performance.html#performance-fetching-batch

I could have sworn that when we were making performance improvements in OpenMRS 1.8, we determined that saying this on the class level also affected collections of this class. I don't understand the documentation as saying anything about whether class-level batching affects collection-level batching.

It won't hurt to put this on the collection also, so I'm fine merging this.

@rkorytkowski @wluyima @dkayiwa whichever of you is community lead this week, can you make sure this gets merged (to master) and backported to at least 1.10.x and 1.9.x?

@djazayeri we confirmed this behaviour by enabling hibernate sql log. :)

@dkayiwa can you also merge this to 1.10.x branch?

I did that and put the commit url on the ticket. :)

On Fri, Nov 15, 2013 at 3:47 PM, shruthidipali notifications@github.comwrote:

@dkayiwa https://github.com/dkayiwa can you also merge this to 1.10.x
branch?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/448#issuecomment-28566516
.

If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.

thanks @dkayiwa