Fixes #14094: mc_issue_add project['name'] is not used

vboctor · vboctor · commit 0faacc35843b · 2012-06-01T22:44:21.000-07:00
Thanks to Tino Böhme (tino) for contributing a patch.
diff --git a/api/soap/mc_api.php b/api/soap/mc_api.php
@@ -86,10 +86,12 @@ function mci_has_administrator_access( $p_user_id, $p_project_id = ALL_PROJECTS
 }
 
 function mci_get_project_id( $p_project ) {
-	if( (int) $p_project['id'] != 0 ) {
+	if ( isset( $p_project['id'] ) && (int) $p_project['id'] != 0 ) {
 		$t_project_id = (int) $p_project['id'];
-	} else {
+	} else if ( isset( $p_project['name'] ) && !is_blank( $p_project['name'] ) ) {
 		$t_project_id = project_get_id_by_name( $p_project['name'] );
+	} else {
+		$t_project_id = ALL_PROJECTS;
 	}
 
 	return $t_project_id;

Original file line number	Diff line number	Diff line change
`@@ -86,10 +86,12 @@ function mci_has_administrator_access( $p_user_id, $p_project_id = ALL_PROJECTS`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`function mci_get_project_id( $p_project ) {`
`89`		`- if( (int) $p_project['id'] != 0 ) {`
	`89`	`+ if ( isset( $p_project['id'] ) && (int) $p_project['id'] != 0 ) {`
`90`	`90`	`$t_project_id = (int) $p_project['id'];`
`91`		`- } else {`
	`91`	`+ } else if ( isset( $p_project['name'] ) && !is_blank( $p_project['name'] ) ) {`
`92`	`92`	`$t_project_id = project_get_id_by_name( $p_project['name'] );`
	`93`	`+ } else {`
	`94`	`+ $t_project_id = ALL_PROJECTS;`
`93`	`95`	`}`
`94`	`96`
`95`	`97`	`return $t_project_id;`