Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions standardization (admin) #687

Merged
merged 23 commits into from Jul 19, 2013
Merged

Actions standardization (admin) #687

merged 23 commits into from Jul 19, 2013

Conversation

norv
Copy link
Contributor

@norv norv commented Jul 17, 2013

This PR makes all admin actions created and routed in a similar way: using Action object.

  • added enabled/disabled and default actions to Action class.
  • I split (finally!) PackageServers from the packages main area. In fact, not only its (sub)actions, but in its own admin area. Probably two tabs will be better there (there's only the tab of the former "Download packages"). The purpose is to make more visible the package servers functionality, and to rework the package manager implementation a bit more into smaller, focused, functions/methods.

Update:

  • added a second tab to Package Servers admin area, with the upload form (upload of packages from user's computer to their server).
  • split a few templates too norv@c146fc8#L2R30

norv added 23 commits July 17, 2013 07:13
@norv
Standardize actions more: ManageAttachments or ManageBoards as examples
98290cd 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Tweak actions for ManageCalendar (to standard, no $_REQUEST['sa'])
af8b55b 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
CoreFeatures, add action_index() to delegate to its action_features().
1f679e4 
This is simply a level of indirection, when the work is all done in
action_features; core features is a form which accepts user input
to switch on/off. If/when we split the user input handling from the
rest of action_features(), we might have a benefit. Now it's just
a matter of standardization attempt: action_index() directs to stuff,
doesn't process usually.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Refactor the redirection to viewfile for $_REQUEST['file'] set.
c2fa393 
Add an activity for viewfile in ManageErrors.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Add enabled/disabled and default actions to Action class.
1cb88e0 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Refactor actions for admin features page to use enabled/disabled and …
7da9d7c 
…default.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Small standardization of actions to languages admin.
0d2ac3a 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Tweaks to bring actions handling to the common pattern.
1a56404 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Refactor enabled/disabled actions for security settings; tweaks.
9aed0ff 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Add enabled/disabled and default to smileys admin actions.
80a298c 
Added another method to Action, to tackle the 'real' sa
which will be set. Not ideal..

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Standardize themes admin actions more; tweak visibility and a useless…
dc47686 
… line.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Split PackageServers in its own template.
5ecb3ec 
(prepare for a PackageServers area)

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Add Package Servers admin area.
94717e5 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Clean up redundant menu sections.
a6906b6 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Make list_getPackages() a method. Missed string in package servers.
c09addb 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Remove unused method InstalledList() (old leftover from createList())
84b0c03 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Rename list method list_packages
403511f 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Fix leftover links to area=packageservers
485539b 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Quick rename: why package upload would be mapped to action_update()? (!)
02db579 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Split ftp_connect() into a little method of its own.
a5e7666 
We will need it again if we make two or more tabs for which we want it.
Document the code.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Wrong syntax for fetchPackageServers() query.
320a93d 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Split the upload form from package servers page, to a second tab of t…
c146fc8 
…he area.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Include the correct file. Tweak $action.
691edbe 
Signed-off-by: Norv <a.w.norv@gmail.com>
norv added a commit that referenced this pull request Jul 19, 2013
@norv
Merge pull request #687 from norv/actions
26203d9 
Actions standardization (admin)
@norv norv merged commit 26203d9 into elkarte:master Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Beta
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@norv