Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ip route showing mask-less IP addresses #1368

Closed
wants to merge 1 commit into from
Closed

Handle ip route showing mask-less IP addresses #1368

wants to merge 1 commit into from

Conversation

steeve
Copy link
Contributor

@steeve steeve commented Aug 1, 2013

Sometimes ip route will show mask-less IPs, so net.ParseCIDR will fail. If it does we check if we can net.ParseIP, and fail only if we can't.
Fixes #1214
Fixes #362

@steeve
Handle ip route showing mask-less IP addresses
2e72882 
Sometimes `ip route` will show mask-less IPs, so net.ParseCIDR will fail. If it does we check if we can net.ParseIP, and fail only if we can't.
Fixes moby#1214
Fixes moby#362
@creack
Copy link
Contributor

creack commented Aug 1, 2013

@steeve could you add a regression test please?

@steeve
Copy link
Contributor Author

steeve commented Aug 1, 2013

I don' t see a test for checkRouteOverlaps?

@creack creack closed this Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker fails to parse ip route output Could not find a free IP address range for interface 'docker0'
2 participants
@steeve @creack