Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Use shorter EditorConfig file syntax #2312

Merged
merged 1 commit into from Apr 18, 2014
Merged

Conversation

treyhunner
Copy link
Contributor

This is just a suggestion.

@openjck
Copy link
Contributor

openjck commented Apr 18, 2014

Thanks @treyhunner. We had trouble making this syntax work a while back, but we might have been missing something. I will take another look.

@darkwing
Copy link
Contributor

Thanks @treyhunner ! If this works I'm a very happy man!

@openjck openjck self-assigned this Apr 18, 2014
@openjck
Copy link
Contributor

openjck commented Apr 18, 2014

Sure enough, this works great. Strangely, the following syntax, which we tried last time...

[{*.css,*.html,*.js,*.json,*.py,*.styl}]

...does not work. Sounds like a bug in EditorConfig. I'll open one and link it from here.

openjck added a commit that referenced this pull request Apr 18, 2014
Use shorter EditorConfig file syntax
@openjck openjck merged commit 8504849 into mdn:master Apr 18, 2014
@openjck
Copy link
Contributor

openjck commented Apr 18, 2014

@treyhunner
Copy link
Contributor Author

Great! Thanks for the bug report. I'll continue the discussion over there.

@treyhunner treyhunner deleted the editorconfig-fix branch April 18, 2014 22:18
@openjck
Copy link
Contributor

openjck commented Apr 18, 2014

Oh hey, you're the @treyhunner from EditorConfig. Thanks for the pull request!

@treyhunner
Copy link
Contributor Author

You're welcome. I worked with a few of the Mozilla guys at the PyCon sprints this week and was tipped off to the fact that you guys use EditorConfig. Glad to see you using it!

@openjck
Copy link
Contributor

openjck commented Apr 18, 2014

Yeah, we love it! Simple, effective, saves us manual work. Can't ask for anything better. 😄

@treyhunner
Copy link
Contributor Author

It can always be better. We have bigger plans that haven't come to fruition yet (e.g. language-specific linters to compliment existing linters that don't check for many of these more file-specific options).

It's community-driven and few of us speak up and help out directly. We would love to eventually see some of the Mozilla team chime in on the EditorConfig mailing list or help us build some tooling to make it even more useful. Or just spread the word. 😃

@openjck
Copy link
Contributor

openjck commented Apr 19, 2014

Joined! I love talking strategy. Let me know if you ever need an outside perspective or user perspective on anything! 😃

@treyhunner
Copy link
Contributor Author

@openjck excellent. I will. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants