add fedorabinary check #695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +68,14 @@ public PropertiesRdfContext(final FedoraResource resource, | |||
| private Iterator<Triple> triplesFromProperties(final FedoraResource n) | |||
| throws RepositoryException { | |||
| LOGGER.trace("Creating triples for node: {}", n); | |||
| final Iterator<Property> allProperties = n.getNode().getProperties(); | |||
| final Iterator<Property> allProperties; | |||
| if (n instanceof FedoraBinary) { | |||
There was a problem hiding this comment.
In the case when the FedoraResource is a FedoraBinary, you should be able to concatenate the properties from both the description and the arg node itself. The end.
There was a problem hiding this comment.
I see, so the logic should be first get properties from n.getNode().getProperties() and then if the node is a binary, append description.getNode().getProperties().
Can you tell me how to append allProperties?
There was a problem hiding this comment.
Iterators.concat() should do the trick.
http://guava-libraries.googlecode.com/svn-history/r46/trunk/javadoc/com/google/common/collect/Iterators.html
|
All test passed. FCREPO-1290 fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow is check whether the child node is a FedoraBinary, get description, and added to the triple. The test is passed, but failed in Fedora Repository HTTP API Module...