Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 512860081534
Choose a base ref
...
head repository: cdk/cdk
compare: e2388c2420fb
Choose a head ref
  • 7 commits
  • 9 files changed
  • 2 contributors

Commits on Sep 29, 2014

  1. Unit test to expose a NPE happening when IAtoms do not have formal ch… 

    …arges set

Change-Id: I22b4eb3c30bf23f0f80c6d92bf33b15f9d1c65d0
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    3b60711 View commit details
    Browse the repository at this point in the history

  2. Fix the NPE: 0 formal charges is the common CDK default if unset 

    Change-Id: I66ef745de55acbe2b6c18672cd3dc45c67794699
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    d0d6d96 View commit details
    Browse the repository at this point in the history

  3. Expose another NPE source 

    Change-Id: I8a4eacd72d3da1a5de2424c50a54d8817511b2a0
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    223b1c1 View commit details
    Browse the repository at this point in the history

  4. Deal with null charges on 'this' too 

    Change-Id: I94f5cea8fef424c597bd00390f056d87782a2247
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    b8abf4e View commit details
    Browse the repository at this point in the history

  5. Reverse order of test to avoid having a potentially unreachable null … 

    …check.

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @johnmay
    Mark B Vine authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    c3ce376 View commit details
    Browse the repository at this point in the history

  6. Replace occurrences of String.indexOf(String) by String.indexOf(Char)… 

    … for single-char strings (PMD report).

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @johnmay
    Mark B Vine authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    eadef42 View commit details
    Browse the repository at this point in the history

  7. Fix incorrect spelling of 'pseudo' in comments and variable name. Ori… 

    …ginal variable deprecated and left in place.

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @johnmay
    Mark B Vine authored and johnmay committed Sep 29, 2014
    Copy the full SHA
    e2388c2 View commit details
    Browse the repository at this point in the history