Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Node#replace to Node#replace_with #14

Closed
wants to merge 1 commit into from
Closed

Change Node#replace to Node#replace_with #14

wants to merge 1 commit into from

Conversation

dlee
Copy link
Contributor

@dlee dlee commented Feb 8, 2014

replace is ambiguous. Use replace_with instead.

@meh
Copy link
Member

meh commented Feb 8, 2014

I'm very unsure about this change. I agree that #replace_with makes a ton more sense as a name, on the other hand Nokogiri uses the same name, and the DOM handling is heavily based on the Nokogiri API.

I don't know if I want to diverge too much from the Nokogiri API since it's one that is fairly well known. Would an alias satisfy you as well? I'd accept that right away.

@adambeynon
Copy link

@meh 👍. Sticking with the nokogiri api when possible is the best way to go. (Also, an alias seems a good option as well).

@dlee
Copy link
Contributor Author

dlee commented Feb 8, 2014

sure, alias sounds like a good way to go.

@meh
Copy link
Member

meh commented Feb 8, 2014

Added the alias by hand.

@meh meh closed this Feb 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dlee @meh @adambeynon