Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change name of files which pass rspec regression test #2183

Merged
merged 1 commit into from Nov 12, 2014
Merged

change name of files which pass rspec regression test #2183

merged 1 commit into from Nov 12, 2014

Conversation

k77ch7
Copy link
Contributor

@k77ch7 k77ch7 commented Nov 12, 2014

This PR is related to #2174. This change adds _spec to name of files which pass rspec regression test.

Rake task

jruby bin/rake spec:regression

Results

Before; on master(5041f5c)

288 examples, 0 failures

After; on master(fdc5a0e)

300 examples, 0 failures

@headius
Copy link
Member

headius commented Nov 12, 2014

Oh, good find. Bad naming practices I guess.

I'm interring from your PR that there are some regression specs that don't pass? That we need to address too.

headius added a commit that referenced this pull request Nov 12, 2014
@headius
Merge pull request #2183 from k77ch7/change_name_of_files_which_pass_…
c8abbf0 
…rspec_regression_test

change name of files which pass rspec regression test
@headius headius merged commit c8abbf0 into jruby:master Nov 12, 2014
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Nov 12, 2014
@headius headius added the tests label Nov 12, 2014
@headius headius self-assigned this Nov 12, 2014
@k77ch7
Copy link
Contributor Author

k77ch7 commented Nov 13, 2014

@headius The following regression specs don't pass.

  • GH-1633_bigdecimal_operations_with_nil.rb
  • GH-1726_File_read_raises_an_enoent.rb
  • GH-1940_symlink_load_path_should_not_expand_in_FILE.rb
  • GH-1960_nonlocal_return_in_define_method_block.rb
  • GH-1980_multiple_nonlocal_returns_in_flight.rb
  • GH-2132_catch_nonlocal_return_lje.rb
  • GH-652_time_add.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@headius headius

Labels
tests
Projects
None yet
Milestone
JRuby 9.0.0.0-pre1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k77ch7 @headius