Fix rdf type jcr mixin translation #125
Conversation
| * @date Oct 23, 2013 | ||
| * @param <T> | ||
| */ | ||
| public class DifferencingIterator<T> { |
There was a problem hiding this comment.
Oh, phoo. It doesn't-- it's from other work and must have gotten swept up into a stage. Should I send another commit with it removed, since you're going to squash it anyway?
There was a problem hiding this comment.
Sounds good... new commit with this class removed.
|
|
||
| // add JCR mixins as rdf:type triples | ||
| final Iterator<NodeType> nodeTypes = forArray(node.getMixinNodeTypes()); | ||
| concat(transform(nodeTypes, nodetype2triple())); |
There was a problem hiding this comment.
guava.transform() returns an interator. In this case, where guava.concat() is only taking a single arg, what purpose does the "concat" server. Would not the "transform" be sufficient?
There was a problem hiding this comment.
That's not Guava's Iterator.concat(), it's our RdfStream.concat().
Incidentally, there is a useful invocation of Iterators.concat() with one argument. If that arg is an Iterator<Iterator>, concat() will flatten it into an Iterator, which we find useful in our code. See:
There was a problem hiding this comment.
Java is not a functional language, but sometimes it plays one on TV.
|
Have we landed on a plan for the other half of this: rdf -> node-type? |
|
I'm working on that now. That's persistence. |
|
|
👍
|
Where did you get a squirrel? |
|
Resolved with: e18ddb8 |
Fixes:
https://www.pivotaltracker.com/story/show/59441130