Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the viewport height math - fixes scrollbar #921

Closed
wants to merge 1 commit into from

Conversation

davidsanders
Copy link

The calculation for newViewportHeight is off by 1px in webkit-based browsers. In cases where the actual grid height is less than the grid's max-height (even if a max-height hasn't been set) vertical-overflow scrollbars are appended to the DOM. Increasing the newViewPort by 1px corrects this issue.

The calculation for newViewportHeight is off by 1px in webkit-based browsers. In cases where the actual grid height is less than the grid's max-height (even if a max-height hasn't been set) vertical-overflow scrollbars are appended to the DOM. Increasing the newViewPort by 1px corrects this issue.
@@ -18,7 +18,7 @@ function ngGridFlexibleHeightPlugin (opts) {
}
}

var newViewportHeight = naturalHeight + 2;
var newViewportHeight = naturalHeight + 3;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the newViewportHeight

@c0bra
Copy link
Contributor

c0bra commented Mar 21, 2014

We'd need to look and see how this affects other browsers than just those that are webkit-based.

@c0bra
Copy link
Contributor

c0bra commented Apr 22, 2014

Thanks! Merged with 37281bc

@c0bra c0bra closed this Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants