Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mojolicious/mojo
base: c512b2e
Choose a base ref
...
head repository: mojolicious/mojo
compare: 2989e0a
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 24, 2011

  1. Make it safe to run many SSL tests in parallel.

    - the problem is that each test process's copy of Mojo::IOLoop::Server writes
      the cert and key to /tmp/mojokey.pem and /tmp/mojocert.pem without any kind
      of lock, so it periodically truncates or deletes a file while it is being
      parsed by another test's openssl library.
    - the fix is to use the pid in the cert/key filenames, so that tests don't
      interfere with each other.
    - you can verify this by running t/mojolicious/tls_lite_app.t in parallel in a
      tight loop:
    
        for i in 1 2 3 4 5 6 7 8 9; do
    	cp t/mojolicious/tls_lite_app.t t/parallel/tls_$i.t
        done
        while true; do
    	make test TEST_FILES=t/parallel/*.t HARNESS_OPTIONS=j9 TEST_TLS=1 || break
        done
    
      Without this patch, I never get more that a few iterations. With the patch
      in place, it has never failed (on my machine).
    nwatkiss committed Dec 24, 2011
    Copy the full SHA
    c195556 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #255 from nwatkiss/multiproc-safe

    Make it safe to run many SSL tests in parallel.
    kraih committed Dec 24, 2011
    Copy the full SHA
    2989e0a View commit details
    Browse the repository at this point in the history