fixed read-only file system compatibility of Mojo::Asset::File

mojolicious · Oct 18, 2014 · 04aa323 · 04aa323 · iakuf · Oct 21, 2014
1 parent 0845559
commit 04aa323
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
 5.52  2014-10-18
+  - Fixed read-only file system compatibility of Mojo::Asset::File.
 
 5.51  2014-10-17
   - Fixed bug in Mojolicious::Validator::Validation where every_param would

diff --git a/lib/Mojo/Asset/File.pm b/lib/Mojo/Asset/File.pm
@@ -17,8 +17,7 @@ has handle => sub {
   my $handle = IO::File->new;
   my $path   = $self->path;
   if (defined $path && -f $path) {
-    $handle->open($path, -w _ ? O_APPEND | O_RDWR : O_RDONLY)
-      or croak qq{Can't open file "$path": $!};
+    $handle->open($path, O_RDONLY) or croak qq{Can't open file "$path": $!};
     return $handle;
   }
 

diff --git a/t/mojo/asset.t b/t/mojo/asset.t
@@ -193,18 +193,6 @@ ok !$asset->is_file, 'stored in memory';
 $asset = $asset->add_chunk('lala');
 ok !$asset->is_file, 'stored in memory';
 
-# Append to file asset
-$file = Mojo::Asset::File->new(cleanup => 0);
-is $file->add_chunk('hello')->slurp, 'hello', 'right content';
-$path = $file->path;
-undef $file;
-ok -e $path, 'file still exists';
-$file = Mojo::Asset::File->new(path => $path, cleanup => 1);
-is $file->add_chunk(' world')->slurp, 'hello world',  'right content';
-is $file->add_chunk('!')->slurp,      'hello world!', 'right content';
-undef $file;
-ok !-e $path, 'file has been cleaned up';
-
 # Temporary directory
 {
   my $tmpdir = tempdir CLEANUP => 1;