unit tests for NamespaceChangedStatementListener

fcrepo · May 23, 2013 · 65be930 · 65be930
1 parent 81f0f7b
commit 65be930
Show file tree

Hide file tree

Showing 2 changed files with 101 additions and 6 deletions.
diff --git a/fcrepo-kernel/src/main/java/org/fcrepo/utils/NamespaceChangedStatementListener.java b/fcrepo-kernel/src/main/java/org/fcrepo/utils/NamespaceChangedStatementListener.java
@@ -25,13 +25,13 @@ public void addedStatement(Statement s) {
 
         LOGGER.debug(">> added statement {}", s);
 
-        if (!s.getPredicate().toString().equals(JcrRdfTools.HAS_NAMESPACE_PREDICATE)) {
+        if (!s.getPredicate().asResource().getURI().equals(JcrRdfTools.HAS_NAMESPACE_PREDICATE)) {
              return;
         }
 
         try {
-            final String prefix = s.getObject().toString();
-            final String uri = s.getSubject().toString();
+            final String prefix = s.getObject().asLiteral().getString();
+            final String uri = s.getSubject().asResource().getURI();
             LOGGER.debug("Registering namespace prefix {} for uri {}", prefix, uri);
             namespaceRegistry.registerNamespace(prefix, uri);
         } catch (RepositoryException e) {
@@ -45,13 +45,13 @@ public void removedStatement(Statement s) {
 
         LOGGER.debug(">> removed statement {}", s);
 
-        if (!s.getPredicate().toString().equals(JcrRdfTools.HAS_NAMESPACE_PREDICATE)) {
+        if (!s.getPredicate().asResource().getURI().equals(JcrRdfTools.HAS_NAMESPACE_PREDICATE)) {
             return;
         }
 
         try {
-            final String prefix = s.getObject().toString();
-            final String uri = s.getSubject().toString();
+            final String prefix = s.getObject().asLiteral().getString();
+            final String uri = s.getSubject().asResource().getURI();
             if (namespaceRegistry.getPrefix(uri).equals(prefix)) {
                 LOGGER.debug("De-registering namespace prefix {} for uri {}", prefix, uri);
                 namespaceRegistry.unregisterNamespace(prefix);

diff --git a/fcrepo-kernel/src/test/java/org/fcrepo/utils/NamespaceChangedStatementListenerTest.java b/fcrepo-kernel/src/test/java/org/fcrepo/utils/NamespaceChangedStatementListenerTest.java
@@ -0,0 +1,95 @@
+package org.fcrepo.utils;
+
+import com.hp.hpl.jena.rdf.model.ResourceFactory;
+import com.hp.hpl.jena.rdf.model.Statement;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.jcr.NamespaceRegistry;
+import javax.jcr.RepositoryException;
+import javax.jcr.Session;
+import javax.jcr.Workspace;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class NamespaceChangedStatementListenerTest {
+
+    private NamespaceChangedStatementListener testObj;
+    private NamespaceRegistry mockNamespaceRegistry;
+
+    @Before
+    public void setUp() throws RepositoryException {
+        Session mockSession = mock(Session.class);
+        Workspace mockWorkspace = mock(Workspace.class);
+        mockNamespaceRegistry = mock(NamespaceRegistry.class);
+        when(mockWorkspace.getNamespaceRegistry()).thenReturn(mockNamespaceRegistry);
+        when(mockSession.getWorkspace()).thenReturn(mockWorkspace);
+        testObj = new NamespaceChangedStatementListener(mockSession);
+
+    }
+
+    @Test
+    public void shouldAddNamespaceStatement() throws RepositoryException {
+        Statement mockStatement = mock(Statement.class);
+        when(mockStatement.getSubject()).thenReturn(ResourceFactory.createResource("uri"));
+        when(mockStatement.getPredicate()).thenReturn(ResourceFactory.createProperty(JcrRdfTools.HAS_NAMESPACE_PREDICATE));
+        when(mockStatement.getObject()).thenReturn(ResourceFactory.createPlainLiteral("123"));
+
+        testObj.addedStatement(mockStatement);
+        verify(mockNamespaceRegistry).registerNamespace("123", "uri");
+    }
+
+    @Test
+    public void shouldIgnoreNonNamespaceStatements() throws RepositoryException {
+        Statement mockStatement = mock(Statement.class);
+        when(mockStatement.getSubject()).thenReturn(ResourceFactory.createResource("uri"));
+        when(mockStatement.getPredicate()).thenReturn(ResourceFactory.createProperty("some-random-predicate"));
+        when(mockStatement.getObject()).thenReturn(ResourceFactory.createPlainLiteral("abc"));
+
+        testObj.addedStatement(mockStatement);
+
+        verify(mockNamespaceRegistry, never()).registerNamespace("abc", "uri");
+    }
+
+
+    @Test
+    public void shouldRemoveNamespaceStatement() throws RepositoryException {
+        Statement mockStatement = mock(Statement.class);
+        when(mockStatement.getSubject()).thenReturn(ResourceFactory.createResource("uri"));
+        when(mockStatement.getPredicate()).thenReturn(ResourceFactory.createProperty(JcrRdfTools.HAS_NAMESPACE_PREDICATE));
+        when(mockStatement.getObject()).thenReturn(ResourceFactory.createPlainLiteral("123"));
+
+        when(mockNamespaceRegistry.getPrefix("uri")).thenReturn("123");
+        testObj.removedStatement(mockStatement);
+        verify(mockNamespaceRegistry).unregisterNamespace("123");
+    }
+
+
+    @Test
+    public void shouldIgnoreNonMatchingNamespacesOnRemoveNamespaceStatement() throws RepositoryException {
+        Statement mockStatement = mock(Statement.class);
+        when(mockStatement.getSubject()).thenReturn(ResourceFactory.createResource("uri"));
+        when(mockStatement.getPredicate()).thenReturn(ResourceFactory.createProperty(JcrRdfTools.HAS_NAMESPACE_PREDICATE));
+        when(mockStatement.getObject()).thenReturn(ResourceFactory.createPlainLiteral("456"));
+
+        when(mockNamespaceRegistry.getPrefix("uri")).thenReturn("123");
+        testObj.removedStatement(mockStatement);
+        verify(mockNamespaceRegistry, never()).unregisterNamespace("456");
+    }
+
+    @Test
+    public void shouldIgnoreNonNamespaceStatementsOnRemove() throws RepositoryException {
+        Statement mockStatement = mock(Statement.class);
+        when(mockStatement.getSubject()).thenReturn(ResourceFactory.createResource("uri"));
+        when(mockStatement.getPredicate()).thenReturn(ResourceFactory.createProperty("some-random-predicate"));
+        when(mockStatement.getObject()).thenReturn(ResourceFactory.createPlainLiteral("abc"));
+
+        testObj.removedStatement(mockStatement);
+
+        verify(mockNamespaceRegistry, never()).unregisterNamespace("abc");
+
+    }
+}