Fix PATCH not working in Transactions #267
Conversation
| String txId = getCurrentTransactionId(session); | ||
| if (txId != null) { | ||
| String txIdWithSlash = "/" + txId; | ||
| pathToValidate = StringUtils.removeStart(txIdWithSlash, absPath); |
There was a problem hiding this comment.
Is removeStart() called on "/txId" for the case when the transaction is working against the root? i.e. when absPath equals "/"?
If some, please add a comment.
There was a problem hiding this comment.
The base URL is removed, take a look at the contstructor of this class. That means the URL here is always context relative. http://localhost:8080/tx:... works as well as http://localhost:8080/abc/tx:... as long as tx is the first thing after the context.
There was a problem hiding this comment.
Running the debugger on this, it seems that line:231 always results in pathToValidate equaling txIdWithSlash. What is the scenario where "removeStart()" comes into play?
There was a problem hiding this comment.
You are right, I accidentially swapped the parameters. Sorry for the trouble. Will write a unit test.
See https://www.pivotaltracker.com/story/show/66262856