fixed is_readable scalability problems in Mojo::Reactor

mojolicious · Jul 26, 2014 · cccc50a · cccc50a
1 parent 3ae054c
commit cccc50a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 
 5.19  2014-07-26
   - Improved support for Unicode anchors in Mojolicious::Plugin::PODRenderer.
+  - Fixed is_readable scalability problems in Mojo::Reactor.
 
 5.18  2014-07-25
   - Improved is_readable performance in Mojo::Reactor.

diff --git a/lib/Mojo/Reactor.pm b/lib/Mojo/Reactor.pm
@@ -2,6 +2,7 @@ package Mojo::Reactor;
 use Mojo::Base 'Mojo::EventEmitter';
 
 use Carp 'croak';
+use IO::Poll qw(POLLIN POLLPRI);
 use Mojo::Loader;
 
 sub again { croak 'Method "again" not implemented by subclass' }
@@ -13,11 +14,8 @@ sub detect {
 
 sub io { croak 'Method "io" not implemented by subclass' }
 
-sub is_readable {
-  my ($self, $handle) = @_;
-  vec(my $read, fileno($handle), 1) = 1;
-  return !!select $read, undef, $read, 0;
-}
+# This may break at some point in the future, but is worth it for performance
+sub is_readable { !(IO::Poll::_poll(0, fileno(pop), POLLIN | POLLPRI) == 0) }
 
 sub is_running { croak 'Method "is_running" not implemented by subclass' }